Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js

Issue 2390733002: [inspector] Make InspectorTest.sendCommand* private (Closed)
Patch Set: addressed comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/inspector/cpu-profiler/console-profile.js ('k') | test/inspector/cpu-profiler/enable-disable.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js
diff --git a/test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js b/test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js
index 484a310fae094849009eb905d7d965823701672f..d266bb0fdc7cdf51b531bd81ce7b0e87be6ad4e5 100644
--- a/test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js
+++ b/test/inspector/cpu-profiler/console-profile-end-parameterless-crash.js
@@ -4,7 +4,7 @@
print("Tests that \"console.profileEnd()\" does not cause crash. (webkit:105759)");
-InspectorTest.evaluateInPage(`
+InspectorTest.addScript(`
function collectProfiles()
{
console.profile();
@@ -19,16 +19,16 @@ InspectorTest.fail = function(message)
InspectorTest.completeTest();
}
-InspectorTest.sendCommand("Profiler.enable", {});
-InspectorTest.sendCommand("Runtime.evaluate", { expression: "collectProfiles()"}, didCollectProfiles);
+Protocol.Profiler.enable();
+Protocol.Runtime.evaluate({ expression: "collectProfiles()"}).then(didCollectProfiles);
var headers = [];
-InspectorTest.eventHandler["Profiler.consoleProfileFinished"] = function(messageObject)
+Protocol.Profiler.onConsoleProfileFinished(function(messageObject)
{
headers.push({
title: messageObject["params"]["title"]
});
-}
+});
function didCollectProfiles(messageObject)
{
« no previous file with comments | « test/inspector/cpu-profiler/console-profile.js ('k') | test/inspector/cpu-profiler/enable-disable.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698