Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 23903056: Add a container window to host the desktop window hierarchy in AURA. (Closed)

Created:
7 years, 3 months ago by ananta
Modified:
7 years, 3 months ago
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

Add a container window to host the desktop window hierarchy in AURA. This ensures that ZOrder changes within this hierarchy don't affect the ZOrder of windows like tooltips which are direct children of the root. This change fixes the issue with the tooltips getting hidden behind the browser window during a tab drag drop operation. Reverted the earlier fix in tooltip_controller.cc which destroyed the tooltip when the mouse left the window bounds. While that works this appears to be a cleaner fix based on a discussion with sky. I disabled the PopupBlockerBrowserTest.WindowFeatures test on linux aura as it fails for some reason with this change. Logged a bug to track that https://code.google.com/p/chromium/issues/detail?id=295299 BUG=292530 R=ben@chromium.org TBR=sky TEST=Covered by new views unittest TooltipAtTopOfZOrderAfterActivation Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224544

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -13 lines) Patch
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 2 3 4 5 1 chunk +10 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 3 4 1 chunk +41 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules.h View 1 2 3 4 1 chunk +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_focus_rules.cc View 1 2 3 4 1 chunk +7 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 3 4 3 chunks +11 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
ananta
7 years, 3 months ago (2013-09-19 17:36:34 UTC) #1
ananta
On 2013/09/19 17:36:34, ananta wrote: Thinking about a good test for this. Will probably be ...
7 years, 3 months ago (2013-09-19 18:13:26 UTC) #2
ananta
On 2013/09/19 18:13:26, ananta wrote: > On 2013/09/19 17:36:34, ananta wrote: > > Thinking about ...
7 years, 3 months ago (2013-09-19 19:00:48 UTC) #3
sky
I'm going to redirect this to Ben. I'm not sure if we ever try to ...
7 years, 3 months ago (2013-09-19 20:46:37 UTC) #4
Ben Goodger (Google)
lgtm
7 years, 3 months ago (2013-09-19 21:19:18 UTC) #5
ananta
7 years, 3 months ago (2013-09-21 01:46:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #6 manually as r224544 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698