Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 23903056: Add a container window to host the desktop window hierarchy in AURA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ui/views/corewm/tooltip_controller.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/files/file_path.h" 6 #include "base/files/file_path.h"
7 #include "base/message_loop/message_loop.h" 7 #include "base/message_loop/message_loop.h"
8 #include "base/path_service.h" 8 #include "base/path_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/autocomplete/autocomplete_match.h" 10 #include "chrome/browser/autocomplete/autocomplete_match.h"
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
328 TemplateURLService* service = TemplateURLServiceFactory::GetForProfile( 328 TemplateURLService* service = TemplateURLServiceFactory::GetForProfile(
329 browser()->profile()); 329 browser()->profile());
330 ui_test_utils::WaitForTemplateURLServiceToLoad(service); 330 ui_test_utils::WaitForTemplateURLServiceToLoad(service);
331 LocationBar* location_bar = browser()->window()->GetLocationBar(); 331 LocationBar* location_bar = browser()->window()->GetLocationBar();
332 ui_test_utils::SendToOmniboxAndSubmit(location_bar, search_string); 332 ui_test_utils::SendToOmniboxAndSubmit(location_bar, search_string);
333 OmniboxEditModel* model = location_bar->GetLocationEntry()->model(); 333 OmniboxEditModel* model = location_bar->GetLocationEntry()->model();
334 EXPECT_EQ(GURL(search_string), model->CurrentMatch(NULL).destination_url); 334 EXPECT_EQ(GURL(search_string), model->CurrentMatch(NULL).destination_url);
335 EXPECT_EQ(ASCIIToUTF16(search_string), model->CurrentMatch(NULL).contents); 335 EXPECT_EQ(ASCIIToUTF16(search_string), model->CurrentMatch(NULL).contents);
336 } 336 }
337 337
338 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, WindowFeatures) { 338 // This test fails on linux AURA with this change
339 // https://codereview.chromium.org/23903056
340 // BUG=https://code.google.com/p/chromium/issues/detail?id=295299
341 // TODO(ananta). Debug and fix this test.
342 #if defined(USE_AURA) && defined(OS_LINUX)
343 #define MAYBE_WindowFeatures DISABLED_WindowFeatures
344 #else
345 #define MAYBE_WindowFeatures WindowFeatures
346 #endif
347 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MAYBE_WindowFeatures) {
339 WebContents* popup = 348 WebContents* popup =
340 RunCheckTest(browser(), 349 RunCheckTest(browser(),
341 base::FilePath(FILE_PATH_LITERAL("popup-window-open.html")), 350 base::FilePath(FILE_PATH_LITERAL("popup-window-open.html")),
342 true, 351 true,
343 false); 352 false);
344 353
345 // Check that the new popup has (roughly) the requested size. 354 // Check that the new popup has (roughly) the requested size.
346 gfx::Size window_size = popup->GetView()->GetContainerSize(); 355 gfx::Size window_size = popup->GetView()->GetContainerSize();
347 EXPECT_TRUE(349 <= window_size.width() && window_size.width() <= 351); 356 EXPECT_TRUE(349 <= window_size.width() && window_size.width() <= 351);
348 EXPECT_TRUE(249 <= window_size.height() && window_size.height() <= 251); 357 EXPECT_TRUE(249 <= window_size.height() && window_size.height() <= 251);
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
406 // popups. 415 // popups.
407 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DenialOfService) { 416 IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, DenialOfService) {
408 GURL url(ui_test_utils::GetTestUrl( 417 GURL url(ui_test_utils::GetTestUrl(
409 base::FilePath(kTestDir), 418 base::FilePath(kTestDir),
410 base::FilePath(FILE_PATH_LITERAL("popup-dos.html")))); 419 base::FilePath(FILE_PATH_LITERAL("popup-dos.html"))));
411 ui_test_utils::NavigateToURL(browser(), url); 420 ui_test_utils::NavigateToURL(browser(), url);
412 ASSERT_EQ(25, GetBlockedContentsCount()); 421 ASSERT_EQ(25, GetBlockedContentsCount());
413 } 422 }
414 423
415 } // namespace 424 } // namespace
OLDNEW
« no previous file with comments | « no previous file | ui/views/corewm/tooltip_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698