Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3366)

Unified Diff: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc

Issue 23903056: Add a container window to host the desktop window hierarchy in AURA. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/views/corewm/tooltip_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc
===================================================================
--- chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (revision 224198)
+++ chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc (working copy)
@@ -335,7 +335,16 @@
EXPECT_EQ(ASCIIToUTF16(search_string), model->CurrentMatch(NULL).contents);
}
-IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, WindowFeatures) {
+// This test fails on linux AURA with this change
+// https://codereview.chromium.org/23903056
+// BUG=https://code.google.com/p/chromium/issues/detail?id=295299
+// TODO(ananta). Debug and fix this test.
+#if defined(USE_AURA) && defined(OS_LINUX)
+#define MAYBE_WindowFeatures DISABLED_WindowFeatures
+#else
+#define MAYBE_WindowFeatures WindowFeatures
+#endif
+IN_PROC_BROWSER_TEST_F(PopupBlockerBrowserTest, MAYBE_WindowFeatures) {
WebContents* popup =
RunCheckTest(browser(),
base::FilePath(FILE_PATH_LITERAL("popup-window-open.html")),
« no previous file with comments | « no previous file | ui/views/corewm/tooltip_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698