Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Unified Diff: content/browser/renderer_host/media/video_capture_controller.h

Issue 23903032: Move NV21 colorspace treatment from VideoCapture java to C++ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reload CL Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_controller.h
diff --git a/content/browser/renderer_host/media/video_capture_controller.h b/content/browser/renderer_host/media/video_capture_controller.h
index 5d33d01163c62c5f661ec523ac552b81a379a65b..a94178ceb7c7fe0b05a53640e57496f60b63e699 100644
--- a/content/browser/renderer_host/media/video_capture_controller.h
+++ b/content/browser/renderer_host/media/video_capture_controller.h
@@ -156,6 +156,10 @@ class CONTENT_EXPORT VideoCaptureController
bool device_in_use_;
VideoCaptureState state_;
+ // For NV21 we have to do color conversion into the intermediate buffer and
+ // from there the rotations.
+ scoped_ptr<uint8[]> i420_intermediate_buffer_;
bulach 2013/09/11 14:59:07 nit: shouldn't this be a scoped_array instead? or
ncarter (slow) 2013/09/11 20:07:23 FWIW This looks fine to me. scoped_array doesn't e
+
DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureController);
};

Powered by Google App Engine
This is Rietveld 408576698