Move NV21 colorspace treatment from VideoCapture java to C++

content/browser/renderer_host/media/video_capture_controller.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // VideoCaptureController is the glue between VideoCaptureHost,
 // VideoCaptureManager and VideoCaptureDevice.
 // It provides functions for VideoCaptureHost to start a VideoCaptureDevice and
 // is responsible for keeping track of shared DIBs and filling them with I420
 // video frames for IPC communication between VideoCaptureHost and
 // VideoCaptureMessageFilter.
@@ skipping 138 matching lines @@
   int chopped_height_;
 
   // It's accessed only on IO thread.
   bool frame_info_available_;
 
   VideoCaptureManager* video_capture_manager_;
 
   bool device_in_use_;
   VideoCaptureState state_;
 
+  // For NV21 we have to do color conversion into the intermediate buffer and
+  // from there the rotations.
+  scoped_ptr<uint8[]> i420_intermediate_buffer_;

[bulach, 2013/09/11 14:59:07]

nit: shouldn't this be a scoped_array instead?
or even better, how about just a vector<uint8> ?

[ncarter (slow), 2013/09/11 20:07:23]

FWIW This looks fine to me. scoped_array doesn't even exist anymore,  scoped_ptr
of an array type is the preferred idiom nowadays. (
https://codereview.chromium.org/14081006 was where scoped_array was removed from
chromium)

+
   DISALLOW_IMPLICIT_CONSTRUCTORS(VideoCaptureController);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_VIDEO_CAPTURE_CONTROLLER_H_