Issue 14081006: Remove scoped_array from Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14081006: Remove scoped_array from Chromium. (Closed)

Created:
7 years, 8 months ago by dcheng

Modified:
7 years, 8 months ago

Reviewers:
willchan no longer on Chromium, awong

CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Remove scoped_array from Chromium. C++11 provides unique_ptr<T[]>, and Chromium has implemented scoped_ptr<T[]> to match its behavior during the transition period. As a result, scoped_array<T> is now redundant and is being removed. BUG=171111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194649 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194680

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -227 lines)			Patch
M	base/callback_internal.h	View	2 chunks	+0 lines, -9 lines	0 comments	Download
M	base/memory/scoped_ptr.h	View	4 chunks	+6 lines, -142 lines	0 comments	Download
M	base/memory/scoped_ptr_unittest.cc	View	1 chunk	+0 lines, -76 lines	0 comments	Download

Total messages: 5 (0 generated)

dcheng

+willchan for the overall/owners review, +ajwong for the visionary/callback-related portions in particular.

7 years, 8 months ago (2013-04-16 19:13:51 UTC) #1

dcheng

Committed patchset #1 manually as r194649 (presubmit successful).

7 years, 8 months ago (2013-04-17 18:58:19 UTC) #4

dcheng

7 years, 8 months ago (2013-04-17 21:17:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r194680 (presubmit successful).