Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 2390213002: Revert of Send a TrackedPreference incident when registry pref validation fails. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
CC:
grt+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send a TrackedPreference incident when registry pref validation fails. (patchset #3 id:40001 of https://codereview.chromium.org/2384213002/ ) Reason for revert: Parent CL https://codereview.chromium.org/2204943002 is suspect of breaking WebRTC Win Tester bots. See https://build.chromium.org/p/chromium.webrtc/builders/Win8%20Tester/builds/28938 Original issue's description: > Send a TrackedPreference incident when registry pref validation fails. > > Note that the new incident types (BYPASS_CLEARED and BYPASS_CHANGED) are only > used when external (registry) validation fails and existing > (secure_preferences-based) validation succeeds. > > BUG=624858 > > Committed: https://crrev.com/1ba5bcd1a74380bb398eeab3787ede5620b5130c > Cr-Commit-Position: refs/heads/master@{#422545} TBR=jialiul@chromium.org,caitkp@chromium.org,gab@chromium.org,proberge@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624858 Committed: https://crrev.com/6954fa8370f0d8f91ee0512d9f47db05efc895f9 Cr-Commit-Position: refs/heads/master@{#422735}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -156 lines) Patch
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate.cc View 4 chunks +6 lines, -18 lines 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc View 8 chunks +29 lines, -64 lines 0 comments Download
M chrome/common/safe_browsing/csd.proto View 1 chunk +0 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/mock_validation_delegate.h View 3 chunks +8 lines, -20 lines 0 comments Download
M components/user_prefs/tracked/mock_validation_delegate.cc View 3 chunks +6 lines, -20 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_filter_unittest.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M components/user_prefs/tracked/pref_hash_store_transaction.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/tracked_atomic_preference.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/tracked_preference_helper.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M components/user_prefs/tracked/tracked_preference_validation_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M components/user_prefs/tracked/tracked_split_preference.cc View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Guido Urdaneta
Created Revert of Send a TrackedPreference incident when registry pref validation fails.
4 years, 2 months ago (2016-10-04 08:48:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2390213002/1
4 years, 2 months ago (2016-10-04 08:48:59 UTC) #3
Guido Urdaneta
On 2016/10/04 08:48:42, Guido Urdaneta wrote: > Created Revert of Send a TrackedPreference incident when ...
4 years, 2 months ago (2016-10-04 08:50:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 08:50:07 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 08:52:16 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6954fa8370f0d8f91ee0512d9f47db05efc895f9
Cr-Commit-Position: refs/heads/master@{#422735}

Powered by Google App Engine
This is Rietveld 408576698