Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1672)

Unified Diff: components/user_prefs/tracked/pref_hash_filter_unittest.cc

Issue 2390213002: Revert of Send a TrackedPreference incident when registry pref validation fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/user_prefs/tracked/pref_hash_filter_unittest.cc
diff --git a/components/user_prefs/tracked/pref_hash_filter_unittest.cc b/components/user_prefs/tracked/pref_hash_filter_unittest.cc
index 1d3afd4b9fc3af307a2f3f7b1cf0015f417b55eb..fa137590bf82bbe239e9f581a0099c95ab75694c 100644
--- a/components/user_prefs/tracked/pref_hash_filter_unittest.cc
+++ b/components/user_prefs/tracked/pref_hash_filter_unittest.cc
@@ -1371,20 +1371,8 @@
ASSERT_EQ(
1u, mock_external_validation_pref_hash_store_->transactions_performed());
- ASSERT_EQ(arraysize(kTestTrackedPrefs),
- mock_validation_delegate_.recorded_validations_count());
-
- // Regular validation should not have any CHANGED prefs.
- ASSERT_EQ(arraysize(kTestTrackedPrefs),
- mock_validation_delegate_.CountValidationsOfState(
- PrefHashStoreTransaction::UNCHANGED));
-
- // External validation should have two CHANGED prefs (kAtomic and kSplit).
- ASSERT_EQ(2u, mock_validation_delegate_.CountExternalValidationsOfState(
- PrefHashStoreTransaction::CHANGED));
- ASSERT_EQ(arraysize(kTestTrackedPrefs) - 2u,
- mock_validation_delegate_.CountExternalValidationsOfState(
- PrefHashStoreTransaction::UNCHANGED));
+ // TODO(proberge): query mock_validation_state_ for number of CHANGED
+ // and UNCHANGED preferences once the class supports external validation.
}
INSTANTIATE_TEST_CASE_P(PrefHashFilterTestInstance,
« no previous file with comments | « components/user_prefs/tracked/mock_validation_delegate.cc ('k') | components/user_prefs/tracked/pref_hash_store_transaction.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698