Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: components/user_prefs/tracked/tracked_split_preference.cc

Issue 2390213002: Revert of Send a TrackedPreference incident when registry pref validation fails. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/user_prefs/tracked/tracked_preference_validation_delegate.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/user_prefs/tracked/tracked_split_preference.cc
diff --git a/components/user_prefs/tracked/tracked_split_preference.cc b/components/user_prefs/tracked/tracked_split_preference.cc
index fc67cfe8668d0f409e5a07edeb3ea3258a83b416..979f90b2388202740da64264b73c400bf01560ff 100644
--- a/components/user_prefs/tracked/tracked_split_preference.cc
+++ b/components/user_prefs/tracked/tracked_split_preference.cc
@@ -64,7 +64,7 @@
helper_.ReportValidationResult(value_state, transaction->GetStoreUMASuffix());
PrefHashStoreTransaction::ValueState external_validation_value_state =
- PrefHashStoreTransaction::UNSUPPORTED;
+ PrefHashStoreTransaction::UNCHANGED;
if (external_validation_transaction) {
std::vector<std::string> invalid_external_validation_keys;
external_validation_value_state =
@@ -73,12 +73,13 @@
helper_.ReportValidationResult(
external_validation_value_state,
external_validation_transaction->GetStoreUMASuffix());
+
+ // TODO(proberge): Call delegate_->OnSplitPreferenceValidation.
}
if (delegate_) {
- delegate_->OnSplitPreferenceValidation(
- pref_path_, dict_value, invalid_keys, value_state,
- external_validation_value_state, helper_.IsPersonal());
+ delegate_->OnSplitPreferenceValidation(pref_path_, dict_value, invalid_keys,
+ value_state, helper_.IsPersonal());
}
TrackedPreferenceHelper::ResetAction reset_action =
helper_.GetAction(value_state);
« no previous file with comments | « components/user_prefs/tracked/tracked_preference_validation_delegate.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698