Deprecate --load-component-extension command line flag

Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
Committed: https://crrev.com/1cc8fc7b0404e98ed920e13a0d5dca44aeac7b71
Cr-Commit-Position: refs/heads/master@{#436453}

[catmullings, 2016-10-04 22:58:03]

Description was changed from

==========
Working implementation and test of --load-component-extension

BUG=615096
==========

to

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, create a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions (landed as
crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[catmullings, 2016-10-04 22:58:34]

Description was changed from

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, create a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions (landed as
crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions (landed as
crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[catmullings, 2016-10-04 23:05:23]

catmullings@chromium.org changed reviewers:
+ rdcronin@google.com

[catmullings, 2016-10-04 23:05:23]

https://codereview.chromium.org/2389703005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/2389703005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_startup_browsertest.cc:310: class
DeprecatedLoadComponentExtensionSwitchBrowserTest
I essentially used the same class structure as the
DisableExtensionsExceptBrowserTest below. Lmk if this type of duplication isn't
good style.

[catmullings, 2016-10-05 19:39:51]

catmullings@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org
- rdcronin@google.com

[catmullings, 2016-10-06 22:18:42]

The CQ bit was checked by catmullings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 22:19:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:23:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:23:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Devlin, 2016-10-10 15:33:27]

Please remember to wrap your title/commit descriptions to 72 chars for git
friendliness. :)

Also, it looks like one of the telemetry tests is failing.  Let's reach out to
the team about it to see if we can move them off it/remove the test.

https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_startup_browsertest.cc:310: class
DeprecatedLoadComponentExtensionSwitchBrowserTest
We don't always add a "this feature was properly removed" test, but I'm
supportive of adding one in this case.  But we can probably put a
TODO(catmullings) to remove this in, say, M57 or so.

https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (left):

https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:27: const char kAllowCrossOriginAuthPrompt[]   
= "allow-cross-origin-auth-prompt";
I'm guessing this was git cl format's doing?  (Usually we don't change unrelated
code because it can pollute the git blame history, but making the tool not do it
is sometimes tricky.)

[catmullings, 2016-10-10 19:17:32]

Description was changed from

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions (landed as
crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
 have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[catmullings, 2016-10-10 19:17:50]

Description was changed from

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
 have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[catmullings, 2016-10-10 19:23:25]

Patchset #3 (id:40001) has been deleted

[catmullings, 2016-10-10 19:30:21]

On 2016/10/10 15:33:27, Devlin wrote:
> Please remember to wrap your title/commit descriptions to 72 chars for git
> friendliness. :)

Done.

> 
> Also, it looks like one of the telemetry tests is failing.  Let's reach out to
> the team about it to see if we can move them off it/remove the test.

Sounds good!

> 
>
https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
> File chrome/browser/extensions/extension_startup_browsertest.cc (right):
> 
>
https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
> chrome/browser/extensions/extension_startup_browsertest.cc:310: class
> DeprecatedLoadComponentExtensionSwitchBrowserTest
> We don't always add a "this feature was properly removed" test, but I'm
> supportive of adding one in this case.  But we can probably put a
> TODO(catmullings) to remove this in, say, M57 or so.
> 
>
https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
> File chrome/common/chrome_switches.cc (left):
> 
>
https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
> chrome/common/chrome_switches.cc:27: const char kAllowCrossOriginAuthPrompt[] 
 
> = "allow-cross-origin-auth-prompt";
> I'm guessing this was git cl format's doing?  (Usually we don't change
unrelated
> code because it can pollute the git blame history, but making the tool not do
it
> is sometimes tricky.)

[catmullings, 2016-10-10 19:30:44]

https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/2389703005/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_startup_browsertest.cc:310: class
DeprecatedLoadComponentExtensionSwitchBrowserTest
On 2016/10/10 15:33:26, Devlin wrote:
> We don't always add a "this feature was properly removed" test, but I'm
> supportive of adding one in this case.  But we can probably put a
> TODO(catmullings) to remove this in, say, M57 or so.

Done.

https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
File chrome/common/chrome_switches.cc (left):

https://codereview.chromium.org/2389703005/diff/20001/chrome/common/chrome_sw...
chrome/common/chrome_switches.cc:27: const char kAllowCrossOriginAuthPrompt[]   
= "allow-cross-origin-auth-prompt";
On 2016/10/10 15:33:26, Devlin wrote:
> I'm guessing this was git cl format's doing?  (Usually we don't change
unrelated
> code because it can pollute the git blame history, but making the tool not do
it
> is sometimes tricky.)

Done.

[catmullings, 2016-10-26 00:42:07]

The CQ bit was checked by catmullings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 00:42:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:44:15]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[catmullings, 2016-10-26 19:20:42]

The CQ bit was checked by catmullings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 19:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 19:47:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:47:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[catmullings, 2016-12-05 20:59:12]

The CQ bit was checked by catmullings@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 20:59:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 21:53:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 21:53:22]

Dry run: This issue passed the CQ dry run.

[catmullings, 2016-12-05 22:19:20]

The CQ bit was checked by catmullings@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:20:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 22:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 22:20:04]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Devlin, 2016-12-05 22:22:57]

Description was changed from

==========
The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[Devlin, 2016-12-05 22:31:02]

lgtm

https://codereview.chromium.org/2389703005/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/2389703005/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/extension_startup_browsertest.cc:310: //
TODO(catmullings): Remove test in future chrome release, perhaps M57.
let's make this maybe M59 now. :)

[catmullings, 2016-12-05 22:36:37]

The CQ bit was checked by catmullings@chromium.org

[catmullings, 2016-12-05 22:36:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2389703005/#ps100001
(title: "Rebase master")

[commit-bot: I haz the power, 2016-12-05 22:37:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 23:39:28]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480977397238580,
"parent_rev": "4ac56e72b47b93e3fd64f5edbd4c18c237299bf1", "commit_rev":
"5473a61473ef6a88af4d8d6fc2700791b7d90752"}

[commit-bot: I haz the power, 2016-12-05 23:39:54]

Description was changed from

==========
Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

[commit-bot: I haz the power, 2016-12-05 23:39:55]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-12-05 23:44:17]

Description was changed from

==========
Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096
==========

to

==========
Deprecate --load-component-extension command line flag

The --load-component-extension is a powerful, yet dangerous flag that developers
have been using to load extensions (for details, see b615096).

This deprecation has been planned in two phases. First, support a
--disable-extensions-except flag, which disables all extensions that are not
specified, but treats the listed extensions as normal extensions
(landed as crrev.org/2166513002/).

Second, remove support for the --load-component-extension flag entirely, which
is this cl.

BUG=615096

Committed: https://crrev.com/1cc8fc7b0404e98ed920e13a0d5dca44aeac7b71
Cr-Commit-Position: refs/heads/master@{#436453}
==========

[commit-bot: I haz the power, 2016-12-05 23:44:19]

Patchset 5 (id:??) landed as
https://crrev.com/1cc8fc7b0404e98ed920e13a0d5dca44aeac7b71
Cr-Commit-Position: refs/heads/master@{#436453}

[c.meldaa, 2017-08-21 01:58:43]

c.meldaa@gmail.com changed reviewers:
+ c.meldaa@gmail.com

[c.meldaa, 2017-08-21 01:58:45]

https://codereview.chromium.org/2389703005/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_startup_browsertest.cc (right):

https://codereview.chromium.org/2389703005/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_startup_browsertest.cc:310: class
DeprecatedLoadComponentExtensionSwitchBrowserTest
On 2016/10/04 23:05:23, catmullings wrote:
> <font><font>V podstatě jsem použil stejnou třídu struktury jako
DisableExtensionsExceptBrowserTest níže. </font><font>Lmk, pokud tento typ
duplikace není dobrý styl.
> </font></font>

Done.