Deprecate --load-component-extension command line flag

chrome/browser/extensions/extension_startup_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/base_switches.h"
@@ skipping 289 matching lines @@
         fourth_extension_path.AppendASCII("extensions").AppendASCII("app2");
     load_extensions_.push_back(fourth_extension_path.value());
   }
 };
 
 IN_PROC_BROWSER_TEST_F(ExtensionsLoadMultipleTest, Test) {
   WaitForServicesToStart(4, true);
   TestInjection(true, true);
 }
 
+class DeprecatedLoadComponentExtensionSwitchBrowserTest

[Devlin, 2016/10/10 15:33:26]

We don't always add a "this feature was properly removed" test, but I'm
supportive of adding one in this case.  But we can probably put a
TODO(catmullings) to remove this in, say, M57 or so.

[catmullings, 2016/10/10 19:30:44]

Done.

+    : public ExtensionBrowserTest {
+ public:
+  DeprecatedLoadComponentExtensionSwitchBrowserTest() {}
+
+  void SetUpCommandLine(base::CommandLine* command_line) override;
+
+  ExtensionRegistry* GetExtensionRegistry() {
+    return ExtensionRegistry::Get(browser()->profile());
+  }
+};
+
+void DeprecatedLoadComponentExtensionSwitchBrowserTest::SetUpCommandLine(
+    base::CommandLine* command_line) {
+  ExtensionBrowserTest::SetUpCommandLine(command_line);
+  base::FilePath fp1(test_data_dir_.AppendASCII("app_dot_com_app/"));
+  base::FilePath fp2(test_data_dir_.AppendASCII("app/"));
+
+  command_line->AppendSwitchASCII(
+      "load-component-extension",
+      fp1.AsUTF8Unsafe() + "," + fp2.AsUTF8Unsafe());
+}
+
+// Tests that the --load-component-extension flag is not supported.
+IN_PROC_BROWSER_TEST_F(DeprecatedLoadComponentExtensionSwitchBrowserTest,
+                       DefunctLoadComponentExtensionFlag) {
+  EXPECT_TRUE(extension_service()->extensions_enabled());
+
+  // Checks that the extensions loaded with the --load-component-extension flag
+  // are not installed.
+  bool is_app_dot_com_extension_installed = false;
+  bool is_app_test_extension_installed = false;
+  for (const scoped_refptr<const extensions::Extension>& extension :
+       GetExtensionRegistry()->enabled_extensions()) {
+    if (extension->name() == "App Dot Com: The App") {
+      is_app_dot_com_extension_installed = true;
+    } else if (extension->name() == "App Test") {
+      is_app_test_extension_installed = true;
+    } else {
+      EXPECT_TRUE(
+          extensions::Manifest::IsComponentLocation(extension->location()));
+    }
+  }
+  EXPECT_FALSE(is_app_dot_com_extension_installed);
+  EXPECT_FALSE(is_app_test_extension_installed);
+}
+
 class DisableExtensionsExceptBrowserTest : public ExtensionBrowserTest {
  public:
   DisableExtensionsExceptBrowserTest() {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override;
 
   ExtensionRegistry* GetExtensionRegistry() {
     return ExtensionRegistry::Get(browser()->profile());
   }
 };
@@ skipping 26 matching lines @@
     } else if (extension->name() == "App Test") {
       is_app_test_extension_enabled = true;
     } else {
       EXPECT_TRUE(
           extensions::Manifest::IsComponentLocation(extension->location()));
     }
   }
   EXPECT_TRUE(is_app_dot_com_extension_enabled);
   EXPECT_TRUE(is_app_test_extension_enabled);
 }