Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2389453002: Remove IsModeMaterial checks in ui/views/ (Closed)

Created:
4 years, 2 months ago by Evan Stade
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove IsModeMaterial checks in ui/views/ BUG=648281 Committed: https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1 Cr-Commit-Position: refs/heads/master@{#422518}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : oops #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -69 lines) Patch
M chrome/browser/ui/views/subtle_notification_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/views/controls/button/custom_button_unittest.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/controls/button/label_button.cc View 2 chunks +1 line, -4 lines 0 comments Download
M ui/views/controls/button/md_text_button.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/views/controls/button/vector_icon_button.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/controls/link.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/controls/link.cc View 1 2 3 chunks +7 lines, -20 lines 1 comment Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M ui/views/examples/vector_example.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Evan Stade
https://codereview.chromium.org/2389453002/diff/40001/ui/views/controls/link.cc File ui/views/controls/link.cc (right): https://codereview.chromium.org/2389453002/diff/40001/ui/views/controls/link.cc#newcode236 ui/views/controls/link.cc:236: if (requested_enabled_color_set_) here is a behavior change. The default ...
4 years, 2 months ago (2016-09-30 22:57:38 UTC) #4
sky
LGTM
4 years, 2 months ago (2016-10-03 15:34:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389453002/40001
4 years, 2 months ago (2016-10-03 19:33:55 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-03 20:44:18 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 20:48:18 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85f972ef60fa34b2a6a86f6b2bed26b427e7c9b1
Cr-Commit-Position: refs/heads/master@{#422518}

Powered by Google App Engine
This is Rietveld 408576698