Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org

Committed: https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5
Cr-Commit-Position: refs/heads/master@{#423054}

[Ken Russell (switch to Gerrit), 2016-10-05 00:40:27]

Description was changed from

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
==========

to

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-10-05 00:40:28]

Description was changed from

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-10-05 00:41:29]

kbr@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-10-05 00:41:30]

Apologies, I took too long investigating the review questions on
https://codereview.chromium.org/2372953002/ and there are now patch conflicts.
CQ'ing TBR'd per review of the other CL.

[Ken Russell (switch to Gerrit), 2016-10-05 00:41:40]

Description was changed from

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

[Ken Russell (switch to Gerrit), 2016-10-05 00:41:45]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2016-10-05 00:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 02:44:17]

Description was changed from

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

to

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

[commit-bot: I haz the power, 2016-10-05 02:44:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-05 02:45:39]

Description was changed from

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org
==========

to

==========
Move special DEPTH_STENCIL attachment logic from command buffers to WebGL1

(piman's https://codereview.chromium.org/2372953002/ , conflicts resolved)

GL_DEPTH_STENCIL_ATTACHMENT is not a real attachment in ES3, but instead is
translated to separate DEPTH and STENCIL attachment. However, WebGL1 has a
concept of a separate DEPTH_STENCIL attachment that is mutually exclusive with
DEPTH and STENCIL attachments.
This CL moves the logic that tracks the separate DEPTH_STENCIL attachment to the
WebGL side, so that the ES3 implementation can consistently track which
attachment is active, in accordance to ES3 rules.

BUG=630568
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=zmo@chromium.org

Committed: https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5
Cr-Commit-Position: refs/heads/master@{#423054}
==========

[commit-bot: I haz the power, 2016-10-05 02:45:39]

Patchset 1 (id:??) landed as
https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5
Cr-Commit-Position: refs/heads/master@{#423054}

[piman, 2016-10-11 00:09:05]

On 2016/10/05 02:45:39, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5
> Cr-Commit-Position: refs/heads/master@{#423054}

Thanks for landing this!

[Ken Russell (switch to Gerrit), 2016-10-11 00:39:56]

On 2016/10/11 00:09:05, piman extended OOO until Oct17 wrote:
> On 2016/10/05 02:45:39, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/761e2ddaa6d3aea34848809174a250291b2615a5
> > Cr-Commit-Position: refs/heads/master@{#423054}
> 
> Thanks for landing this!

Thank you again for writing it! It's a significant simplification and I can't
think of anyone (myself included) who could have driven it through end-to-end.