Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 2389193004: Always use ChannelMojo for content child processes. (Closed)

Created:
4 years, 2 months ago by Sam McNally
Modified:
4 years, 2 months ago
CC:
chrome-apps-syd-reviews_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, fuzzing_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, piman+watch_chromium.org, rickyz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Always use ChannelMojo for content child processes. All content child processes now use ChannelMojo. This removes the option to not use ChannelMojo. BUG=604282 Committed: https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626 Cr-Commit-Position: refs/heads/master@{#423375}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -199 lines) Patch
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M chrome/common/crash_keys.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/broker/nacl_broker_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_broker_host_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nonsfi/nonsfi_listener.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 5 chunks +2 lines, -8 lines 0 comments Download
M content/browser/utility_process_host_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/child/child_thread_impl.h View 4 chunks +1 line, -6 lines 0 comments Download
M content/child/child_thread_impl.cc View 6 chunks +25 lines, -58 lines 0 comments Download
M content/common/child_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/child_process_host_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M content/common/in_process_child_thread_params.h View 2 chunks +2 lines, -6 lines 0 comments Download
M content/common/in_process_child_thread_params.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/child_process_host.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/zygote/zygote_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_channel_posix.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_logging.cc View 1 chunk +0 lines, -1 line 0 comments Download
D ipc/ipc_switches.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ipc/ipc_switches.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M tools/ipc_fuzzer/message_replay/replay_process.cc View 1 2 chunks +7 lines, -26 lines 0 comments Download

Messages

Total messages: 22 (15 generated)
Sam McNally
4 years, 2 months ago (2016-10-05 09:04:06 UTC) #9
Ken Rockot(use gerrit already)
So awesome!!!1 LGTM.
4 years, 2 months ago (2016-10-05 14:15:41 UTC) #10
Sam McNally
+jam for everything outside //ipc.
4 years, 2 months ago (2016-10-05 22:33:23 UTC) #14
jam
lgtm
4 years, 2 months ago (2016-10-05 23:03:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389193004/40001
4 years, 2 months ago (2016-10-05 23:40:39 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-06 01:18:07 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 01:21:29 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75ce65c46a94b3fa6336e43a7ca56040537db626
Cr-Commit-Position: refs/heads/master@{#423375}

Powered by Google App Engine
This is Rietveld 408576698