Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1612)

Unified Diff: content/child/child_thread_impl.h

Issue 2389193004: Always use ChannelMojo for content child processes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/utility_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/child_thread_impl.h
diff --git a/content/child/child_thread_impl.h b/content/child/child_thread_impl.h
index bb878de997a6bc0399bba8bea4eee441189109dc..c2759aed7b999a024467326d5785f84152f356a7 100644
--- a/content/child/child_thread_impl.h
+++ b/content/child/child_thread_impl.h
@@ -240,7 +240,7 @@ class CONTENT_EXPORT ChildThreadImpl
// We create the channel first without connecting it so we can add filters
// prior to any messages being received, then connect it afterwards.
- void ConnectChannel(bool use_mojo_channel);
+ void ConnectChannel();
// IPC message handlers.
void OnShutdown();
@@ -276,7 +276,6 @@ class CONTENT_EXPORT ChildThreadImpl
associated_interface_provider_bindings_;
mojom::RouteProviderAssociatedPtr remote_route_provider_;
- std::string channel_name_;
std::unique_ptr<IPC::SyncChannel> channel_;
// Allows threads other than the main thread to send sync messages.
@@ -336,8 +335,6 @@ struct ChildThreadImpl::Options {
class Builder;
- std::string channel_name;
- bool use_mojo_channel;
bool auto_start_mojo_shell_connection;
bool connect_to_browser;
scoped_refptr<base::SequencedTaskRunner> browser_process_io_runner;
@@ -353,10 +350,8 @@ class ChildThreadImpl::Options::Builder {
Builder();
Builder& InBrowserProcess(const InProcessChildThreadParams& params);
- Builder& UseMojoChannel(bool use_mojo_channel);
Builder& AutoStartMojoShellConnection(bool auto_start);
Builder& ConnectToBrowser(bool connect_to_browser);
- Builder& WithChannelName(const std::string& channel_name);
Builder& AddStartupFilter(IPC::MessageFilter* filter);
Options Build();
« no previous file with comments | « content/browser/utility_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698