Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2389193004: Always use ChannelMojo for content child processes. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index fd8d6625f60abc5273aa5feac1de29f59df3bbd2..21a70dd0b4b2fac7db9fb5778801501e770cf8e2 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -172,7 +172,6 @@
#include "ipc/ipc_channel.h"
#include "ipc/ipc_channel_mojo.h"
#include "ipc/ipc_logging.h"
-#include "ipc/ipc_switches.h"
#include "media/base/media_switches.h"
#include "mojo/edk/embedder/embedder.h"
#include "mojo/public/cpp/bindings/associated_interface_ptr.h"
@@ -877,9 +876,7 @@ bool RenderProcessHostImpl::Init() {
sent_render_process_ready_ = false;
// Setup the IPC channel.
- const std::string channel_id =
- IPC::Channel::GenerateVerifiedChannelID(std::string());
- channel_ = CreateChannelProxy(channel_id);
+ channel_ = CreateChannelProxy();
// Note that Channel send is effectively paused and unpaused at various points
// during startup, and existing code relies on a fragile relative message
@@ -933,7 +930,6 @@ bool RenderProcessHostImpl::Init() {
// on separate threads.
in_process_renderer_.reset(
g_renderer_main_thread_factory(InProcessChildThreadParams(
- channel_id,
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO),
mojo_child_connection_->service_token())));
@@ -964,7 +960,6 @@ bool RenderProcessHostImpl::Init() {
if (!renderer_prefix.empty())
cmd_line->PrependWrapper(renderer_prefix);
AppendRendererCommandLine(cmd_line);
- cmd_line->AppendSwitchASCII(switches::kProcessChannelID, channel_id);
// Spawn the child process asynchronously to avoid blocking the UI thread.
// As long as there's no renderer prefix, we can use the zygote process
@@ -1000,8 +995,7 @@ bool RenderProcessHostImpl::Init() {
return true;
}
-std::unique_ptr<IPC::ChannelProxy> RenderProcessHostImpl::CreateChannelProxy(
- const std::string& channel_id) {
+std::unique_ptr<IPC::ChannelProxy> RenderProcessHostImpl::CreateChannelProxy() {
scoped_refptr<base::SingleThreadTaskRunner> runner =
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
IPC::mojom::ChannelBootstrapPtr bootstrap;
« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | content/browser/utility_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698