Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

DepsCache file in goma should be different by builder.
However, the DepsCache directory was moved to /b/c/goma_deps_cache/.
This had 2 problems:
  1. actually the directory does not exist,
  2. since DepsCache cache filename was constant, we cannot use
     different filename by builder.

Now goma can take GOMA_DEPS_CACHE_FILE environment variable, so we can
use arbitrary name for cache filename. So, I'd like to use builder name
as DepsCache filename.

When relative path is passed to GOMA_DEPS_CACHE_FILE, it will be placed
in GOMA_CACHE_DIR.

BUG=645047
Committed: https://chromium.googlesource.com/chromium/tools/build/+/86a752d056c021924af4ba6281e751daa28ee837

[shinyak, 2016-10-03 07:12:40]

Description was changed from

==========
Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

DepsCache file in goma should be different by builder.
However, the DepsCache directory was moved to /b/c/goma_deps_cache/.
This had 2 problems:
  1. actually the directory does not exist,
  2. since DepsCache cache filename was constant, we cannot use
     different filename by builder.

Now goma can take GOMA_DEPS_CACHE_FILE environment variable, so we can
use arbitrary name for cache filename. So, I'd like to use builder name
as DepsCache filename.

BUG=645047
==========

to

==========
Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

DepsCache file in goma should be different by builder.
However, the DepsCache directory was moved to /b/c/goma_deps_cache/.
This had 2 problems:
  1. actually the directory does not exist,
  2. since DepsCache cache filename was constant, we cannot use
     different filename by builder.

Now goma can take GOMA_DEPS_CACHE_FILE environment variable, so we can
use arbitrary name for cache filename. So, I'd like to use builder name
as DepsCache filename.

When relative path is passed to GOMA_DEPS_CACHE_FILE, it will be placed
in GOMA_CACHE_DIR.

BUG=645047
==========

[shinyak, 2016-10-03 07:15:21]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:15:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 07:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 07:21:38]

Dry run: Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31a23a281c45bd10)

[shinyak, 2016-10-03 07:52:02]

The CQ bit was checked by shinyak@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:52:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 07:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 07:58:37]

Dry run: This issue passed the CQ dry run.

[shinyak, 2016-10-03 08:00:52]

shinyak@chromium.org changed reviewers:
+ phajdan.jr@chromium.org, tikuta@chromium.org, ukai@chromium.org,
yyanagisawa@chromium.org

[shinyak, 2016-10-03 08:04:44]

The important change is in these two files.

scripts/slave/compile.py
scripts/slave/recipe_modules/chromium/api.py

[tikuta, 2016-10-03 08:25:00]

lgtm

https://codereview.chromium.org/2388683002/diff/60001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2388683002/diff/60001/scripts/slave/compile.p...
scripts/slave/compile.py:508: 'DEPRECATED. Use --goma-deps-cache-file')
indent?

[shinyak, 2016-10-03 08:34:08]

https://codereview.chromium.org/2388683002/diff/60001/scripts/slave/compile.py
File scripts/slave/compile.py (right):

https://codereview.chromium.org/2388683002/diff/60001/scripts/slave/compile.p...
scripts/slave/compile.py:508: 'DEPRECATED. Use --goma-deps-cache-file')
On 2016/10/03 08:25:00, tikuta wrote:
> indent?

Done.

[Paweł Hajdan Jr., 2016-10-03 10:04:54]

LGTM w/comment

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/api.py:193: except KeyError:  # pragma:
nocover
Could you remove the try-except? We could get KeyError on goma_deps_cache, but
we no longer use it.

[ukai, 2016-10-04 01:24:44]

lgtm

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/api.py:187: # Use explicit goma deps cache
dir if it's set in the path config.
update comment?

[shinyak, 2016-10-04 08:19:17]

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium/api.py (right):

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/api.py:187: # Use explicit goma deps cache
dir if it's set in the path config.
Removed the comment.

https://codereview.chromium.org/2388683002/diff/80001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium/api.py:193: except KeyError:  # pragma:
nocover
On 2016/10/03 10:04:54, Paweł Hajdan Jr. wrote:
> Could you remove the try-except? We could get KeyError on goma_deps_cache, but
> we no longer use it.

Done.

[ukai, 2016-10-05 01:10:21]

lgtm

[Yoshisato Yanagisawa, 2016-10-05 02:06:07]

lgtm

[shinyak, 2016-10-05 03:21:41]

The CQ bit was checked by shinyak@chromium.org

[shinyak, 2016-10-05 03:21:43]

The patchset sent to the CQ was uploaded after l-g-t-m from tikuta@chromium.org,
phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2388683002/#ps100001
(title: "Fix")

[commit-bot: I haz the power, 2016-10-05 03:21:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 03:34:57]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/31abae2dad4e2310)

[shinyak, 2016-10-05 03:43:46]

Oh, needs rebase & train

[shinyak, 2016-10-05 03:47:04]

The CQ bit was checked by shinyak@chromium.org

[shinyak, 2016-10-05 03:47:07]

The patchset sent to the CQ was uploaded after l-g-t-m from tikuta@chromium.org,
yyanagisawa@chromium.org, ukai@chromium.org, phajdan.jr@chromium.org
Link to the patchset: https://codereview.chromium.org/2388683002/#ps120001
(title: "Rebased")

[commit-bot: I haz the power, 2016-10-05 03:47:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 03:56:16]

Description was changed from

==========
Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

DepsCache file in goma should be different by builder.
However, the DepsCache directory was moved to /b/c/goma_deps_cache/.
This had 2 problems:
  1. actually the directory does not exist,
  2. since DepsCache cache filename was constant, we cannot use
     different filename by builder.

Now goma can take GOMA_DEPS_CACHE_FILE environment variable, so we can
use arbitrary name for cache filename. So, I'd like to use builder name
as DepsCache filename.

When relative path is passed to GOMA_DEPS_CACHE_FILE, it will be placed
in GOMA_CACHE_DIR.

BUG=645047
==========

to

==========
Re-enable DepsCache using GOMA_DEPS_CACHE_FILE

DepsCache file in goma should be different by builder.
However, the DepsCache directory was moved to /b/c/goma_deps_cache/.
This had 2 problems:
  1. actually the directory does not exist,
  2. since DepsCache cache filename was constant, we cannot use
     different filename by builder.

Now goma can take GOMA_DEPS_CACHE_FILE environment variable, so we can
use arbitrary name for cache filename. So, I'd like to use builder name
as DepsCache filename.

When relative path is passed to GOMA_DEPS_CACHE_FILE, it will be placed
in GOMA_CACHE_DIR.

BUG=645047

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/86a752d056c021924af4...
==========

[commit-bot: I haz the power, 2016-10-05 03:56:19]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/tools/build/+/86a752d056c021924af4...