Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: scripts/slave/compile.py

Issue 2388683002: Re-enable DepsCache using GOMA_DEPS_CACHE_FILE (Closed)
Patch Set: Rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/api.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/compile.py
diff --git a/scripts/slave/compile.py b/scripts/slave/compile.py
index 44f7e0e422968573a3ea70139c6b5bce894c542c..de55ec62eac6f49608fe6d2f0dca7ebeac6ec651 100755
--- a/scripts/slave/compile.py
+++ b/scripts/slave/compile.py
@@ -163,8 +163,12 @@ def goma_setup(options, env):
# Enable DepsCache. DepsCache caches the list of files to send goma server.
# This will greatly improve build speed when cache is warmed.
- # The cache file is stored in the target output directory.
- env['GOMA_DEPS_CACHE_DIR'] = (
+ if options.goma_deps_cache_file:
+ env['GOMA_DEPS_CACHE_FILE'] = options.goma_deps_cache_file
+ else:
+ # TODO(shinyak): GOMA_DEPS_CACHE_DIR will be removed from goma in future.
+ # GOMA_DEPS_CACHE_FILE should be used.
+ env['GOMA_DEPS_CACHE_DIR'] = (
options.goma_deps_cache_dir or options.target_output_dir)
if options.goma_hermetic:
@@ -497,8 +501,11 @@ def get_parsed_options():
option_parser.add_option('--goma-cache-dir',
default=DEFAULT_GOMA_CACHE_DIR,
help='specify goma cache directory')
+ option_parser.add_option('--goma-deps-cache-file',
+ help='specify goma deps cache file')
option_parser.add_option('--goma-deps-cache-dir',
- help='specify goma deps cache directory')
+ help='specify goma deps cache directory. '
+ 'DEPRECATED. Use --goma-deps-cache-file')
option_parser.add_option('--goma-hermetic', default='error',
help='Set goma hermetic mode')
option_parser.add_option('--goma-enable-remote-link', default=None,
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/api.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698