Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2388623002: Replace internal uses of BlinkMacSystemFont on Mac with system-ui (Closed)

Created:
4 years, 2 months ago by kojii
Modified:
4 years, 2 months ago
Reviewers:
drott, eae, Steven Holte
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace internal uses of BlinkMacSystemFont on Mac with system-ui This patch replaces internal uses of "BlinkMacSystemFont", Blink's non-standard extension on Mac, with the standard "system-ui" generic font family. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 Committed: https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b Cr-Commit-Position: refs/heads/master@{#426743}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Add UseCounter, rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Cleanup and rebase #

Patch Set 6 : Fix non-Mac builds #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -32 lines) Patch
M third_party/WebKit/LayoutTests/platform/mac/fast/css/css2-system-fonts-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutThemeMac.mm View 1 2 3 4 5 6 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.h View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/FontCache.cpp View 1 2 3 4 5 2 chunks +20 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/ThemeMac.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 51 (38 generated)
kojii
PTAL. drott@: platform eae@: core holte@: tools/metrics Bots is in trouble, but I believe it ...
4 years, 2 months ago (2016-10-19 06:24:56 UTC) #24
eae
OK, LGTM
4 years, 2 months ago (2016-10-19 15:47:37 UTC) #31
Steven Holte
histograms lgtm
4 years, 2 months ago (2016-10-19 18:57:31 UTC) #32
drott
LGTM
4 years, 2 months ago (2016-10-20 15:09:12 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388623002/100001
4 years, 2 months ago (2016-10-21 02:19:44 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/291177) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 2 months ago (2016-10-21 02:23:15 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388623002/120001
4 years, 2 months ago (2016-10-21 03:11:28 UTC) #40
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/150272) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
4 years, 2 months ago (2016-10-21 03:27:46 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388623002/120001
4 years, 2 months ago (2016-10-21 03:39:27 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/316679)
4 years, 2 months ago (2016-10-21 05:16:44 UTC) #46
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388623002/120001
4 years, 2 months ago (2016-10-21 05:40:06 UTC) #48
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 2 months ago (2016-10-21 07:12:00 UTC) #49
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:27:56 UTC) #51
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b
Cr-Commit-Position: refs/heads/master@{#426743}

Powered by Google App Engine
This is Rietveld 408576698