|
|
Chromium Code Reviews|
Created:
4 years, 2 months ago by kojii Modified:
4 years, 2 months ago CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionReplace internal uses of BlinkMacSystemFont on Mac with system-ui
This patch replaces internal uses of "BlinkMacSystemFont", Blink's
non-standard extension on Mac, with the standard "system-ui" generic
font family.
By eliminating internal uses, the aliasing is moved from FontCache
to CSS resolving time. This allows access to the document, which is
needed for per-document use counter.
BUG=554590, 654679
Committed: https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b
Cr-Commit-Position: refs/heads/master@{#426743}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Add UseCounter, rebase #Patch Set 4 : Rebase #Patch Set 5 : Cleanup and rebase #Patch Set 6 : Fix non-Mac builds #Patch Set 7 : Rebase #Messages
Total messages: 51 (38 generated)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
Description was changed from ========== WIP: legacy-mac-system-ui BUG= ========== to ========== Enable "system-ui" generic font family This patch enables the "system-ui" generic font family on all platforms. Following changes are planned but not included in this CL: 1. Content sets the localized system font to Blink on Linux/CrOS[1]. 2. Remove internal use of "BlinkMacSystemFont" and add UMA[2]. 3. On Mac, expand "system-ui" to underlying name by size. This is expected to improve http://crbug.com/627609 . 4. On Mac, expand "system-ui" to underlying cascading list. This is more complex than other items and is expected to take longer. [1] https://codereview.chromium.org/2138613002 [2] https://codereview.chromium.org/2388623002 BUG=654679 ==========
Description was changed from ========== Enable "system-ui" generic font family This patch enables the "system-ui" generic font family on all platforms. Following changes are planned but not included in this CL: 1. Content sets the localized system font to Blink on Linux/CrOS[1]. 2. Remove internal use of "BlinkMacSystemFont" and add UMA[2]. 3. On Mac, expand "system-ui" to underlying name by size. This is expected to improve http://crbug.com/627609 . 4. On Mac, expand "system-ui" to underlying cascading list. This is more complex than other items and is expected to take longer. [1] https://codereview.chromium.org/2138613002 [2] https://codereview.chromium.org/2388623002 BUG=654679 ========== to ========== ==========
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== ========== to ========== Eliminate internal uses of BlinkMacSystemFont on Mac This patch eliminates internal uses of BlinkMacSystemFont, Blink's non-standard extension on Mac. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 ==========
Description was changed from ========== Eliminate internal uses of BlinkMacSystemFont on Mac This patch eliminates internal uses of BlinkMacSystemFont, Blink's non-standard extension on Mac. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 ========== to ========== Replace internal uses of BlinkMacSystemFont on Mac with system-ui This patch replaces internal uses of "BlinkMacSystemFont", Blink's non-standard extension on Mac, with the standard "system-ui" generic font family. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 ==========
kojii@chromium.org changed reviewers: + drott@chromium.org, eae@chromium.org, holte@chromium.org
PTAL. drott@: platform eae@: core holte@: tools/metrics Bots is in trouble, but I believe it passes, only minor change from PS4. drott@, I hope the description answers to your question in the previous CL, if not, happy to discuss more.
The CQ bit was unchecked by kojii@chromium.org
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
The CQ bit was checked by kojii@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
OK, LGTM
histograms lgtm
LGTM
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from drott@chromium.org, eae@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2388623002/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by kojii@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #7 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Replace internal uses of BlinkMacSystemFont on Mac with system-ui This patch replaces internal uses of "BlinkMacSystemFont", Blink's non-standard extension on Mac, with the standard "system-ui" generic font family. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 ========== to ========== Replace internal uses of BlinkMacSystemFont on Mac with system-ui This patch replaces internal uses of "BlinkMacSystemFont", Blink's non-standard extension on Mac, with the standard "system-ui" generic font family. By eliminating internal uses, the aliasing is moved from FontCache to CSS resolving time. This allows access to the document, which is needed for per-document use counter. BUG=554590, 654679 Committed: https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b Cr-Commit-Position: refs/heads/master@{#426743} ==========
Message was sent while issue was closed.
Patchset 7 (id:??) landed as https://crrev.com/dcc99dfb57774beee88deeb95e8f5753d6d10f8b Cr-Commit-Position: refs/heads/master@{#426743} |
