Replace internal uses of BlinkMacSystemFont on Mac with system-ui

third_party/WebKit/Source/core/layout/LayoutThemeMac.mm

 /*
  * Copyright (C) 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Google, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
@@ skipping 232 matching lines @@
   NSFont* font = systemNSFont(systemFontID);
   if (!font)
     return;
 
   NSFontManager* fontManager = [NSFontManager sharedFontManager];
   fontStyle = ([fontManager traitsOfFont:font] & NSItalicFontMask)
                   ? FontStyleItalic
                   : FontStyleNormal;
   fontWeight = toFontWeight([fontManager weightOfFont:font]);
   fontSize = [font pointSize];
-  fontFamily = @"BlinkMacSystemFont";
+  fontFamily = FontFamilyNames::system_ui;
 }
 
 bool LayoutThemeMac::needsHackForTextControlWithFontFamily(
     const AtomicString& family) const {
   // This hack is only applied on OSX 10.9.
   // https://code.google.com/p/chromium/issues/detail?id=515989#c8
-  return IsOS10_9() && family == "BlinkMacSystemFont";
+  return IsOS10_9() && family == FontFamilyNames::system_ui;
 }
 
 static RGBA32 convertNSColorToColor(NSColor* color) {
   NSColor* colorInColorSpace =
       [color colorUsingColorSpaceName:NSDeviceRGBColorSpace];
   if (colorInColorSpace) {
     static const double scaleFactor = nextafter(256.0, 0.0);
     return makeRGB(
         static_cast<int>(scaleFactor * [colorInColorSpace redComponent]),
         static_cast<int>(scaleFactor * [colorInColorSpace greenComponent]),
@@ skipping 200 matching lines @@
     // FIXME: This is horrible, but there is not much else that can be done.
     // Menu lists cannot draw properly when scaled. They can't really draw
     // properly when transformed either. We can't detect the transform case
     // at style adjustment time so that will just have to stay broken.  We
     // can however detect that we're zooming. If zooming is in effect we
     // treat it like the control is styled.
     if (style.effectiveZoom() != 1.0f)
       return true;
     if (!fontSizeMatchesToControlSize(style))
       return true;
-    if (style.getFontDescription().family().family() != "BlinkMacSystemFont")
+    if (style.getFontDescription().family().family() !=
+        FontFamilyNames::system_ui)
       return true;
     if (!style.height().isIntrinsicOrAuto())
       return true;
     // NSPopUpButtonCell on macOS 10.9 doesn't support
     // NSUserInterfaceLayoutDirectionRightToLeft.
     if (IsOS10_9() && style.direction() == RTL)
       return true;
   }
   // Some other cells don't work well when scaled.
   if (style.effectiveZoom() != 1) {
@@ skipping 145 matching lines @@
 }
 
 void LayoutThemeMac::setFontFromControlSize(ComputedStyle& style,
                                             NSControlSize controlSize) const {
   FontDescription fontDescription;
   fontDescription.setIsAbsoluteSize(true);
   fontDescription.setGenericFamily(FontDescription::SerifFamily);
 
   NSFont* font = [NSFont
       systemFontOfSize:[NSFont systemFontSizeForControlSize:controlSize]];
-  fontDescription.firstFamily().setFamily(@"BlinkMacSystemFont");
+  fontDescription.firstFamily().setFamily(FontFamilyNames::system_ui);
   fontDescription.setComputedSize([font pointSize] * style.effectiveZoom());
   fontDescription.setSpecifiedSize([font pointSize] * style.effectiveZoom());
 
   // Reset line height.
   style.setLineHeight(ComputedStyle::initialLineHeight());
 
   // TODO(esprehn): The fontSelector manual management is buggy and error prone.
   FontSelector* fontSelector = style.font().getFontSelector();
   if (style.setFontDescription(fontDescription))
     style.font().update(fontSelector);
@@ skipping 443 matching lines @@
 }
 
 bool LayoutThemeMac::shouldUseFallbackTheme(const ComputedStyle& style) const {
   ControlPart part = style.appearance();
   if (part == CheckboxPart || part == RadioPart)
     return style.effectiveZoom() != 1;
   return false;
 }
 
 }  // namespace blink