Don't remove any entries from the pending deopts table before a throw.

Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the stack being unwound. These entries will instead be removed during DeoptimizeCopyFrame.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/9dda00c8b010d529151a90a62a6c29a896c3aba6

[rmacnak, 2016-10-03 23:44:11]

rmacnak@google.com changed reviewers:
+ fschneider@google.com

[rmacnak, 2016-10-03 23:44:11]

runtime/vm/stack_frame.h: 126: error: unreachable code
Dumping native stack trace for thread 38fe
  [0x00000000008b9c1d] dart::Profiler::DumpStackTrace(bool)
  [0x00000000008b9c1d] dart::Profiler::DumpStackTrace(bool)
  [0x00000000005cc77d] dart::DynamicAssertionHelper::Fail(char const*, ...)
  [0x0000000000935f54] dart::StackFrame::GetCallerPc() const
  [0x0000000000935806]
dart::StackFrameIterator::FrameSetIterator::NextFrame(bool)
  [0x00000000009355c1] dart::StackFrameIterator::NextFrame()
  [0x00000000008bbfec] dart::ProfilerDartExitStackWalker::walk()
  [0x00000000008ba9ea] dart::Profiler::SampleThread(dart::Thread*,
dart::InterruptedThreadState const&)
  [0x00000000009540d7]
dart::ThreadInterrupterLinux::ThreadInterruptSignalHandler(int, siginfo_t*,
void*)
  [0x00007fb0525be330] Unknown symbol
  [0x0000000000963fdc] dart::Zone::DeleteAll()
  [0x00000000009647a7] dart::StackZone::~StackZone()
  [0x00000000005fa345] dart::StackResource::UnwindAbove(dart::Thread*,
dart::StackResource*)
  [0x00000000006961cf] Unknown symbol
  [0x0000000000695d02] Unknown symbol
  [0x00000000006954c6] dart::Exceptions::Throw(dart::Thread*, dart::Instance
const&)
  [0x00000000006953f9]
dart::Exceptions::ThrowByType(dart::Exceptions::ExceptionType, dart::Array
const&)
  [0x0000000000ad06f4]
dart::BootstrapNatives::DN_Object_noSuchMethod(_Dart_NativeArguments*)
  [0x00007fb05285063a] Unknown symbol
  [0x00007fb050b84f53] Unknown symbol
  [0x00007fb05285110c] Unknown symbol
  [0x00007fb0528509d7] Unknown symbol
  [0x0000000000676430] dart::DartEntry::InvokeFunction(dart::Function const&,
dart::Array const&, dart::Array const&)
  [0x000000000067619a] dart::DartEntry::InvokeFunction(dart::Function const&,
dart::Array const&)
  [0x0000000000677320] dart::DartEntry::InvokeNoSuchMethod(dart::Instance
const&, dart::String const&, dart::Array const&, dart::Array const&)
  [0x000000000064d02d]
dart::DRT_InvokeClosureNoSuchMethod(dart::NativeArguments)
  [0x00007fb0528504dc] Unknown symbol
  [0x00007fb0528531ab] Unknown symbol
  [0x00007fb0501c5ed3] Unknown symbol
  [0x00007fb04ff82ed8] Unknown symbol
  [0x00007fb05285110c] Unknown symbol
  [0x00007fb04ff80da7] Unknown symbol
  [0x00007fb04ff83dfe] Unknown symbol
  [0x00007fb050b7b6a2] Unknown symbol
  [0x00007fb050b7b4f5] Unknown symbol
  [0x00007fb050b72a2e] Unknown symbol
  [0x00007fb050b7a885] Unknown symbol
  [0x00007fb050b4f311] Unknown symbol
  [0x00007fb050b7a595] Unknown symbol
  [0x00007fb0528509d7] Unknown symbol
  [0x0000000000676430] dart::DartEntry::InvokeFunction(dart::Function const&,
dart::Array const&, dart::Array const&)
  [0x000000000067619a] dart::DartEntry::InvokeFunction(dart::Function const&,
dart::Array const&)
  [0x0000000000679137] dart::DartLibraryCalls::HandleMessage(dart::Object
const&, dart::Instance const&)
  [0x000000000077b961]
dart::IsolateMessageHandler::HandleMessage(dart::Message*)
  [0x00000000007ac513]
dart::MessageHandler::HandleMessages(dart::MonitorLocker*, bool, bool)
  [0x00000000007acb86] dart::MessageHandler::TaskCallback()
  [0x00000000007ad629] dart::MessageHandlerTask::Run()
-- End of DumpStackTrace

[Florian Schneider, 2016-10-03 23:48:21]

Lgtm

[rmacnak, 2016-10-03 23:51:17]

Description was changed from

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removing during
DeoptimizeCopyFrame.
==========

to

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removed during
DeoptimizeCopyFrame.

BUG=
==========

[rmacnak, 2016-10-03 23:51:28]

Description was changed from

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removed during
DeoptimizeCopyFrame.

BUG=
==========

to

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removed during
DeoptimizeCopyFrame.
==========

[rmacnak, 2016-10-03 23:52:09]

Description was changed from

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removed during
DeoptimizeCopyFrame.
==========

to

==========
Don't remove any entries from the pending deopts table before a throw.

The profiler may attempt a stack walk between removing these entries and the
stack being unwound. These entries will instead be removed during
DeoptimizeCopyFrame.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9dda00c8b010d529151a90a62a6c29a896c3aba6
==========

[rmacnak, 2016-10-03 23:52:10]

Committed patchset #2 (id:20001) manually as
9dda00c8b010d529151a90a62a6c29a896c3aba6 (presubmit successful).