Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: runtime/vm/exceptions.cc

Issue 2388343002: Don't remove any entries from the pending deopts table before a throw. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/vm/stack_frame.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/exceptions.h" 5 #include "vm/exceptions.h"
6 6
7 #include "platform/address_sanitizer.h" 7 #include "platform/address_sanitizer.h"
8 8
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 // Jump to the deopt stub instead of the catch handler. 229 // Jump to the deopt stub instead of the catch handler.
230 program_counter = 230 program_counter =
231 StubCode::DeoptimizeLazyFromThrow_entry()->EntryPoint(); 231 StubCode::DeoptimizeLazyFromThrow_entry()->EntryPoint();
232 if (FLAG_trace_deoptimization) { 232 if (FLAG_trace_deoptimization) {
233 THR_Print("Throwing to frame scheduled for lazy deopt fp=%" Pp "\n", 233 THR_Print("Throwing to frame scheduled for lazy deopt fp=%" Pp "\n",
234 frame_pointer); 234 frame_pointer);
235 } 235 }
236 break; 236 break;
237 } 237 }
238 } 238 }
239 for (intptr_t i = pending_deopts->length() - 1; i >= 0; i--) {
240 // Leave the mapping at fp itself for use in DeoptimizeCopyFrame.
241 if ((*pending_deopts)[i].fp() < frame_pointer) {
242 pending_deopts->RemoveAt(i);
243 }
244 }
245 #endif // !DBC 239 #endif // !DBC
246 240
247 241
248 #if defined(USING_SIMULATOR) 242 #if defined(USING_SIMULATOR)
249 // Unwinding of the C++ frames and destroying of their stack resources is done 243 // Unwinding of the C++ frames and destroying of their stack resources is done
250 // by the simulator, because the target stack_pointer is a simulated stack 244 // by the simulator, because the target stack_pointer is a simulated stack
251 // pointer and not the C++ stack pointer. 245 // pointer and not the C++ stack pointer.
252 246
253 // Continue simulating at the given pc in the given frame after setting up the 247 // Continue simulating at the given pc in the given frame after setting up the
254 // exception object in the kExceptionObjectReg register and the stacktrace 248 // exception object in the kExceptionObjectReg register and the stacktrace
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
769 } 763 }
770 764
771 return DartLibraryCalls::InstanceCreate(library, 765 return DartLibraryCalls::InstanceCreate(library,
772 *class_name, 766 *class_name,
773 *constructor_name, 767 *constructor_name,
774 arguments); 768 arguments);
775 } 769 }
776 770
777 771
778 } // namespace dart 772 } // namespace dart
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/stack_frame.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698