Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: runtime/vm/stack_frame.h

Issue 2388343002: Don't remove any entries from the pending deopts table before a throw. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_STACK_FRAME_H_ 5 #ifndef VM_STACK_FRAME_H_
6 #define VM_STACK_FRAME_H_ 6 #define VM_STACK_FRAME_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/object.h" 9 #include "vm/object.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 ASSERT(raw_pc != StubCode::DeoptimizeLazyFromThrow_entry()->EntryPoint()); 116 ASSERT(raw_pc != StubCode::DeoptimizeLazyFromThrow_entry()->EntryPoint());
117 if (raw_pc == StubCode::DeoptimizeLazyFromReturn_entry()->EntryPoint()) { 117 if (raw_pc == StubCode::DeoptimizeLazyFromReturn_entry()->EntryPoint()) {
118 uword fp = GetCallerFp(); 118 uword fp = GetCallerFp();
119 MallocGrowableArray<PendingLazyDeopt>* pending_deopts = 119 MallocGrowableArray<PendingLazyDeopt>* pending_deopts =
120 isolate()->pending_deopts(); 120 isolate()->pending_deopts();
121 for (intptr_t i = 0; i < pending_deopts->length(); i++) { 121 for (intptr_t i = 0; i < pending_deopts->length(); i++) {
122 if ((*pending_deopts)[i].fp() == fp) { 122 if ((*pending_deopts)[i].fp() == fp) {
123 return (*pending_deopts)[i].pc(); 123 return (*pending_deopts)[i].pc();
124 } 124 }
125 } 125 }
126 UNREACHABLE(); 126 FATAL("Missing pending deopt entry");
127 } 127 }
128 return raw_pc; 128 return raw_pc;
129 } 129 }
130 130
131 uword fp_; 131 uword fp_;
132 uword sp_; 132 uword sp_;
133 uword pc_; 133 uword pc_;
134 Thread* thread_; 134 Thread* thread_;
135 135
136 // The iterators FrameSetIterator and StackFrameIterator set the private 136 // The iterators FrameSetIterator and StackFrameIterator set the private
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 386
387 387
388 DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) { 388 DART_FORCE_INLINE static uword LocalVarAddress(uword fp, intptr_t index) {
389 return fp + LocalVarIndex(0, index) * kWordSize; 389 return fp + LocalVarIndex(0, index) * kWordSize;
390 } 390 }
391 391
392 392
393 } // namespace dart 393 } // namespace dart
394 394
395 #endif // VM_STACK_FRAME_H_ 395 #endif // VM_STACK_FRAME_H_
OLDNEW
« no previous file with comments | « runtime/vm/exceptions.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698