Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2388213003: Revert of Analytic AntiAlias for Convex Shapes (Closed)

Created:
4 years, 2 months ago by stephana
Modified:
4 years, 2 months ago
Reviewers:
reed1, caryclark, liyuqian
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Analytic AntiAlias for Convex Shapes (patchset #14 id:260001 of https://codereview.chromium.org/2221103002/ ) Reason for revert: Breaks iOS build. Original issue's description: > Implement AnalyticAA for convex shapes. > > Design doc: go/analyticAA > > A performance test can be found here: https://docs.google.com/a/google.com/spreadsheets/d/1n9LSjFzrQzx0hovFddWey0GSMXNRjl1oFuSypMlHWZk/edit?usp=sharing > > Our best case is filling big triangles, which according to our experiment has ~2.9x speedup. Our worst case is filling small ovals/circles, which has a ~1.06x slowdown. > > To see how our new algorithm changes the DM images, see: https://x20web.corp.google.com/~liyuqian/dmdiff/index.html > The most significant changes are in convexpaths and analytic_antialias_convex > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2221103002 > > Committed: https://skia.googlesource.com/skia/+/7795822807478143120c33228b68d2ab3918af2c TBR=reed@google.com,caryclark@google.com,liyuqian@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/d36baa7a4a5ae3cc94cc4a45379f55658f80c0a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -2143 lines) Patch
M bench/nanobench.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M dm/DM.cpp View 3 chunks +0 lines, -7 lines 0 comments Download
M gyp/core.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
D src/core/SkAAAConstants.h View 1 chunk +0 lines, -220 lines 0 comments Download
D src/core/SkAnalyticEdge.h View 1 chunk +0 lines, -154 lines 0 comments Download
D src/core/SkAnalyticEdge.cpp View 1 chunk +0 lines, -245 lines 0 comments Download
M src/core/SkBlitter.cpp View 1 chunk +4 lines, -9 lines 0 comments Download
M src/core/SkEdge.h View 3 chunks +1 line, -2 lines 0 comments Download
M src/core/SkEdge.cpp View 4 chunks +3 lines, -16 lines 0 comments Download
M src/core/SkEdgeBuilder.h View 4 chunks +5 lines, -13 lines 0 comments Download
M src/core/SkEdgeBuilder.cpp View 8 chunks +42 lines, -155 lines 0 comments Download
M src/core/SkScan.h View 3 chunks +0 lines, -22 lines 0 comments Download
D src/core/SkScan_AAAPath.cpp View 1 chunk +0 lines, -1279 lines 0 comments Download
M src/core/SkScan_AntiPath.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
stephana
Created Revert of Analytic AntiAlias for Convex Shapes
4 years, 2 months ago (2016-10-04 16:55:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388213003/1
4 years, 2 months ago (2016-10-04 16:55:55 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:56:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d36baa7a4a5ae3cc94cc4a45379f55658f80c0a6

Powered by Google App Engine
This is Rietveld 408576698