Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2387983002: Worker: Reflow comments in worker components (Closed)

Created:
4 years, 2 months ago by nhiroki
Modified:
4 years, 2 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, dglazkov+blink, nhiroki, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, haraken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Worker: Reflow comments in worker components Context: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/xGUEAYEB9dc This CL covers: - third_party/WebKit/Source/core/workers/ - third_party/WebKit/Source/modules/compositorworker/ - third_party/WebKit/Source/modules/serviceworkers/ - third_party/WebKit/public/platform/modules/serviceworker/ - third_party/WebKit/public/web/modules/serviceworker/ BUG=563793 Committed: https://crrev.com/ab02cff195528182f60268891250537a6cf2f163 Cr-Commit-Position: refs/heads/master@{#422360}

Patch Set 1 : automatically generated #

Patch Set 2 : manually tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -55 lines) Patch
M third_party/WebKit/Source/core/workers/AbstractWorker.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/AbstractWorker.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/workers/SharedWorker.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerInspectorProxy.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerLoaderProxy.h View 1 2 chunks +15 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/workers/WorkletScriptLoader.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 6 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCache.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h View 1 2 chunks +9 lines, -8 lines 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerContextClient.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/modules/serviceworker/WebServiceWorkerNetworkProvider.h View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nhiroki
PTAL, thanks!
4 years, 2 months ago (2016-10-03 00:19:18 UTC) #3
falken
lgtm
4 years, 2 months ago (2016-10-03 00:44:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387983002/20001
4 years, 2 months ago (2016-10-03 00:51:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-03 02:13:58 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 02:17:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab02cff195528182f60268891250537a6cf2f163
Cr-Commit-Position: refs/heads/master@{#422360}

Powered by Google App Engine
This is Rietveld 408576698