third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 2387983002: Worker: Reflow comments in worker components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 2387983002: Worker: Reflow comments in worker components (Closed)

Patch Set: manually tweak Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index a6c88d5bd97e82f7219176387272344526ee9db9..5bfdcc44afc45394e4ebcb605818d1d6e96b3d02 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -228,7 +228,8 @@ void ServiceWorkerContainer::registerServiceWorkerImpl(

RefPtr<SecurityOrigin> documentOrigin = executionContext->getSecurityOrigin();

String errorMessage;

- // Restrict to secure origins: https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged

+ // Restrict to secure origins:

+ // https://w3c.github.io/webappsec/specs/powerfulfeatures/#settings-privileged

if (!executionContext->isSecureContext(errorMessage)) {

callbacks->onError(WebServiceWorkerError(

WebServiceWorkerError::ErrorTypeSecurity, errorMessage));