third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp - Issue 2387983002: Worker: Reflow comments in worker components

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 2387983002: Worker: Reflow comments in worker components (Closed)

Patch Set: manually tweak Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

index 53f508c2e89ad7699923380e13d4ea183d283a0c..1073dbc2cab68e2b01822a5d313e1ecc33734b40 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp

@@ -105,7 +105,8 @@ ServiceWorkerClients::ServiceWorkerClients() {}

ScriptPromise ServiceWorkerClients::get(ScriptState* scriptState,

const String& id) {

ExecutionContext* executionContext = scriptState->getExecutionContext();

- // TODO(jungkees): May be null due to worker termination: http://crbug.com/413518.

+ // TODO(jungkees): May be null due to worker termination:

+ // http://crbug.com/413518.

if (!executionContext)

return ScriptPromise();