Issue 2387723002: Test CL to demonstrate GN + hermetic toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2387723002: Test CL to demonstrate GN + hermetic toolchain

Created:
4 years, 2 months ago by erikchen

Modified:
4 years, 2 months ago

Reviewers:

CC:
chromium-reviews, blink-reviews

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

...wip remove print logging. formatting. Begin the process of making all tools hermeticized. BUG=

Patch Set 1 #

Patch Set 2 : more fixes. #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+109 lines, -40 lines)			Patch
M	build/config/mac/base_rules.gni	View		1 chunk	+10 lines, -7 lines	0 comments	Download
M	build/config/mac/compile_xib.py	View		2 chunks	+10 lines, -3 lines	0 comments	Download
M	build/config/mac/xcrun.py	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/secondary/third_party/crashpad/crashpad/util/BUILD.gn	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	build/toolchain/mac/BUILD.gn	View	1	11 chunks	+11 lines, -10 lines	0 comments	Download
M	build/toolchain/toolchain.gni	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	chrome/app/nibs/BUILD.gn	View		1 chunk	+11 lines, -2 lines	0 comments	Download
M	chrome/app/nibs/generate_localizer.py	View		4 chunks	+22 lines, -11 lines	0 comments	Download
M	chrome/tools/build/mac/run_verify_order.py	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/policy/BUILD.gn	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/build/scripts/gperf.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/build/scripts/in_generator.py	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/build/scripts/rule_bison.py	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	third_party/WebKit/Source/core/BUILD.gn	View		2 chunks	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/BUILD.gn	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/crashpad/crashpad/util/mach/mig.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

erikchen

4 years, 2 months ago (2016-09-30 18:21:22 UTC) #1

Description was changed from

==========
...wip


remove print logging.


formatting.


Begin the process of making all tools hermeticized.

BUG=
==========

to

==========
...wip


remove print logging.


formatting.


Begin the process of making all tools hermeticized.

BUG=
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages