Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: build/config/mac/compile_xib.py

Issue 2387723002: Test CL to demonstrate GN + hermetic toolchain
Patch Set: more fixes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/mac/base_rules.gni ('k') | build/config/mac/xcrun.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/compile_xib.py
diff --git a/build/config/mac/compile_xib.py b/build/config/mac/compile_xib.py
index 845f8c179550bbd339cbd306a008671cf8573607..f1e04ddbdd751f52e14bed5eac3ce2062273a543 100644
--- a/build/config/mac/compile_xib.py
+++ b/build/config/mac/compile_xib.py
@@ -4,6 +4,7 @@
import argparse
+import logging
import os
import re
import subprocess
@@ -18,13 +19,19 @@ def main():
help='Path to output bundle.')
parser.add_argument('-i', '--input', required=True,
help='Path to input xib or storyboard.')
+ parser.add_argument('--developer_dir', required=False,
+ help='Path to ibtool.')
args, unknown_args = parser.parse_known_args()
- ibtool_args = [
- 'xcrun', 'ibtool',
+ ibtool_args = ['xcrun', 'ibtool']
+ if (args.developer_dir):
+ os.environ['DEVELOPER_DIR'] = args.developer_dir
+ # ibtools_args = [ args.ibtool_path ]
+
+ ibtool_args.extend([
'--errors', '--warnings', '--notices',
'--output-format', 'human-readable-text'
- ]
+ ])
ibtool_args += unknown_args
ibtool_args += [
'--compile',
« no previous file with comments | « build/config/mac/base_rules.gni ('k') | build/config/mac/xcrun.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698