Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/app/nibs/BUILD.gn

Issue 2387723002: Test CL to demonstrate GN + hermetic toolchain
Patch Set: more fixes. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/toolchain/toolchain.gni ('k') | chrome/app/nibs/generate_localizer.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/app/nibs/BUILD.gn
diff --git a/chrome/app/nibs/BUILD.gn b/chrome/app/nibs/BUILD.gn
index 0be22170e55f675f8f566acc7ea7a2cd8945e624..67ca3afbc836419fcd189f43844e874e41db54f5 100644
--- a/chrome/app/nibs/BUILD.gn
+++ b/chrome/app/nibs/BUILD.gn
@@ -67,6 +67,15 @@ action("localizer_table") {
outputs = [
table_path,
]
- args = [ rebase_path(table_path, root_build_dir) ] +
- rebase_path(translated_xibs, root_build_dir)
+ args = [
+ "--output_path",
+ rebase_path(table_path, root_build_dir),
+ ]
+ if (!use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
+ args += rebase_path(translated_xibs, root_build_dir)
}
« no previous file with comments | « build/toolchain/toolchain.gni ('k') | chrome/app/nibs/generate_localizer.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698