Issue 23875048: Use explicitly-sized enums in GrGLProgramDesc::KeyHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23875048: Use explicitly-sized enums in GrGLProgramDesc::KeyHeader (Closed)

Created:
7 years, 3 months ago by Chris Dalton

Modified:
7 years, 2 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Use explicitly-sized enums in GrGLProgramDesc::KeyHeader Uses enums explicitly sized to 8 bits in GrGLProgramDesc::KeyHeader, instead of storing them as uint8_t values. This avoids the need to static_cast them. Committed: http://code.google.com/p/skia/source/detail?r=11560

Patch Set 1 #

Patch Set 2 : Fix build error with tests #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -13 lines)			Patch
M	src/gpu/gl/GrGLProgram.cpp	View		4 chunks	+4 lines, -6 lines	0 comments	Download
M	src/gpu/gl/GrGLProgramDesc.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	tests/GLProgramsTest.cpp	View	1	2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/23875048/3001

7 years, 2 months ago (2013-10-01 12:06:53 UTC) #3

Message was sent while issue was closed.

Change committed as 11560

Expand Messages | Collapse Messages