Fix menu scroll indicators and highlights overlapping the menu border.

Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
Committed: https://crrev.com/82da69342711aa7a1683add6dc98470eec4120a7
Cr-Commit-Position: refs/heads/master@{#422907}

[Bret, 2016-09-29 22:05:41]

The CQ bit was checked by bsep@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 22:06:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bret, 2016-09-29 23:42:08]

Description was changed from

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
==========

to

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
==========

[Bret, 2016-09-29 23:42:08]

bsep@chromium.org changed reviewers:
+ pkasting@chromium.org, sky@chromium.org

[Bret, 2016-09-29 23:42:19]

https://codereview.chromium.org/2387503002/diff/20001/chrome/browser/ui/views...
File chrome/browser/ui/views/infobars/infobar_view.h (left):

https://codereview.chromium.org/2387503002/diff/20001/chrome/browser/ui/views...
chrome/browser/ui/views/infobars/infobar_view.h:96: void
RunMenuAt(ui::MenuModel* menu_model,
Deleted this because it's unused and it was confusing me when I was
investigating this issue.

[sky, 2016-09-30 02:46:42]

https://codereview.chromium.org/2387503002/diff/20001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_item_view.cc (right):

https://codereview.chromium.org/2387503002/diff/20001/ui/views/controls/menu/...
ui/views/controls/menu/menu_item_view.cc:767: // Avoids painting over the menu
border.
Doesn't MenuScrollViewContainer::Layout inset by the border as necessary? Why do
you need to do it here as well?

https://codereview.chromium.org/2387503002/diff/20001/ui/views/round_rect_pai...
File ui/views/round_rect_painter.h (right):

https://codereview.chromium.org/2387503002/diff/20001/ui/views/round_rect_pai...
ui/views/round_rect_painter.h:31: enum { kBorderWidth = 1 };
Style guide says enums first.

[Bret, 2016-09-30 18:27:53]

https://codereview.chromium.org/2387503002/diff/20001/ui/views/controls/menu/...
File ui/views/controls/menu/menu_item_view.cc (right):

https://codereview.chromium.org/2387503002/diff/20001/ui/views/controls/menu/...
ui/views/controls/menu/menu_item_view.cc:767: // Avoids painting over the menu
border.
On 2016/09/30 02:46:42, sky wrote:
> Doesn't MenuScrollViewContainer::Layout inset by the border as necessary? Why
do
> you need to do it here as well?

Ok... I didn't notice that layout had some weird inset stuff going on. It
resolves to MenuConfig.menu_horizontal_border_size which is just 0... changing
it to 1 works and is cleaner, so I went with that.

https://codereview.chromium.org/2387503002/diff/20001/ui/views/round_rect_pai...
File ui/views/round_rect_painter.h (right):

https://codereview.chromium.org/2387503002/diff/20001/ui/views/round_rect_pai...
ui/views/round_rect_painter.h:31: enum { kBorderWidth = 1 };
On 2016/09/30 02:46:42, sky wrote:
> Style guide says enums first.

Done.

[Peter Kasting, 2016-09-30 20:17:39]

I assume you added me for the infobars change and sky for the ui/ changes.  (For
clarity, it's always good to explicitly state what you want each person to do if
you have multiple reviewers, avoiding overlap unless it's intentional.)

LGTM on the infobar code removal.  This may have been left over from extension
infobars.

[sky, 2016-10-03 15:49:31]

LGTM

[Bret, 2016-10-04 18:27:37]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2016-10-04 18:28:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:27:11]

Description was changed from

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
==========

to

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
==========

[commit-bot: I haz the power, 2016-10-04 20:27:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-04 20:29:04]

Description was changed from

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996
==========

to

==========
Fix menu scroll indicators and highlights overlapping the menu border.

The border is drawn with a 1 DIP inset, so the overflow scroll
indicators and item highlights also need to be inset by 1 DIP.

BUG=635996

Committed: https://crrev.com/82da69342711aa7a1683add6dc98470eec4120a7
Cr-Commit-Position: refs/heads/master@{#422907}
==========

[commit-bot: I haz the power, 2016-10-04 20:29:05]

Patchset 3 (id:??) landed as
https://crrev.com/82da69342711aa7a1683add6dc98470eec4120a7
Cr-Commit-Position: refs/heads/master@{#422907}