Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: ui/views/controls/menu/menu_scroll_view_container.cc

Issue 2387503002: Fix menu scroll indicators and highlights overlapping the menu border. (Closed)
Patch Set: inset in layout instead Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/menu/menu_config.cc ('k') | ui/views/round_rect_painter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_scroll_view_container.cc
diff --git a/ui/views/controls/menu/menu_scroll_view_container.cc b/ui/views/controls/menu/menu_scroll_view_container.cc
index cbbe72ee221720b984c3856353e56123427fb6d6..a126820718be5c63b9c5a5aadc83d15bd12064d6 100644
--- a/ui/views/controls/menu/menu_scroll_view_container.cc
+++ b/ui/views/controls/menu/menu_scroll_view_container.cc
@@ -283,10 +283,9 @@ void MenuScrollViewContainer::CreateDefaultBorder() {
? kBorderPaddingDueToRoundedCorners
: 0;
- int top = menu_config.menu_vertical_border_size + padding;
- int left = menu_config.menu_horizontal_border_size + padding;
- int bottom = menu_config.menu_vertical_border_size + padding;
- int right = menu_config.menu_horizontal_border_size + padding;
+ const int vertical_inset = menu_config.menu_vertical_border_size + padding;
+ const int horizontal_inset =
+ menu_config.menu_horizontal_border_size + padding;
if (menu_config.use_outer_border) {
SkColor color = GetNativeTheme()
@@ -296,9 +295,10 @@ void MenuScrollViewContainer::CreateDefaultBorder() {
SetBorder(views::Border::CreateBorderPainter(
base::MakeUnique<views::RoundRectPainter>(color,
menu_config.corner_radius),
- gfx::Insets(top, left, bottom, right)));
+ gfx::Insets(vertical_inset, horizontal_inset)));
} else {
- SetBorder(Border::CreateEmptyBorder(top, left, bottom, right));
+ SetBorder(Border::CreateEmptyBorder(vertical_inset, horizontal_inset,
+ vertical_inset, horizontal_inset));
}
}
« no previous file with comments | « ui/views/controls/menu/menu_config.cc ('k') | ui/views/round_rect_painter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698