Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.cc

Issue 2387503002: Fix menu scroll indicators and highlights overlapping the menu border. (Closed)
Patch Set: inset in layout instead Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.h ('k') | ui/views/controls/menu/menu_config.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/infobars/infobar_view.cc
diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc
index 52087b797f8dcff1c77a41d6c3043d73d60da604..e339db259bd57d7c10687347d8784b2e06a2d137 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_view.cc
@@ -225,22 +225,6 @@ int InfoBarView::OffsetY(views::View* view) const {
(bar_target_height() - bar_height());
}
-void InfoBarView::RunMenuAt(ui::MenuModel* menu_model,
- views::MenuButton* button,
- views::MenuAnchorPosition anchor) {
- DCHECK(owner()); // We'd better not open any menus while we're closing.
- gfx::Point screen_point;
- views::View::ConvertPointToScreen(button, &screen_point);
- menu_runner_.reset(
- new views::MenuRunner(menu_model, views::MenuRunner::HAS_MNEMONICS));
- // Ignore the result since we don't need to handle a deleted menu specially.
- ignore_result(menu_runner_->RunMenuAt(GetWidget(),
- button,
- gfx::Rect(screen_point, button->size()),
- anchor,
- ui::MENU_SOURCE_NONE));
-}
-
void InfoBarView::AddViewToContentArea(views::View* view) {
child_container_->AddChildView(view);
}
« no previous file with comments | « chrome/browser/ui/views/infobars/infobar_view.h ('k') | ui/views/controls/menu/menu_config.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698