Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23874013: Remove old activation code and disable-focus-controller flags (Closed)

Created:
7 years, 3 months ago by oshima
Modified:
7 years, 3 months ago
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove old activation code and disable-focus-controller flags BUG=285339, 285364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221529

Patch Set 1 : rebse #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1895 lines) Patch
M ash/ash.gyp View 2 chunks +0 lines, -7 lines 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 1 chunk +3 lines, -5 lines 1 comment Download
M ash/shell.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/shell.cc View 4 chunks +8 lines, -27 lines 0 comments Download
D ash/wm/activation_controller.h View 1 chunk +0 lines, -126 lines 0 comments Download
D ash/wm/activation_controller.cc View 1 chunk +0 lines, -413 lines 0 comments Download
D ash/wm/activation_controller_delegate.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ash/wm/activation_controller_unittest.cc View 1 chunk +0 lines, -575 lines 0 comments Download
D ash/wm/ash_activation_controller.h View 1 chunk +0 lines, -37 lines 0 comments Download
D ash/wm/ash_activation_controller.cc View 1 chunk +0 lines, -96 lines 0 comments Download
D ash/wm/ash_activation_controller_unittest.cc View 1 chunk +0 lines, -168 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/corewm/corewm_switches.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/corewm/corewm_switches.cc View 2 chunks +0 lines, -19 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/views/widget/desktop_aura/desktop_activation_client.h View 1 chunk +0 lines, -90 lines 0 comments Download
D ui/views/widget/desktop_aura/desktop_activation_client.cc View 1 chunk +0 lines, -190 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +4 lines, -22 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 3 chunks +8 lines, -17 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 4 chunks +9 lines, -19 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.h View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_window_event_filter.cc View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
oshima
ben -> ui/views jamescook -> ash/ erg -> linux_aura change in ui/views
7 years, 3 months ago (2013-09-04 20:32:26 UTC) #1
Ben Goodger (Google)
lgtm, awesome thanks!
7 years, 3 months ago (2013-09-04 21:08:07 UTC) #2
Elliot Glaysher
lgtm
7 years, 3 months ago (2013-09-04 21:10:23 UTC) #3
James Cook
LGTM https://codereview.chromium.org/23874013/diff/11001/ash/shelf/shelf_widget_unittest.cc File ash/shelf/shelf_widget_unittest.cc (right): https://codereview.chromium.org/23874013/diff/11001/ash/shelf/shelf_widget_unittest.cc#newcode43 ash/shelf/shelf_widget_unittest.cc:43: // crbug.com/285364. Thanks for filing a bug for ...
7 years, 3 months ago (2013-09-04 22:53:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23874013/11001
7 years, 3 months ago (2013-09-04 23:25:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82827
7 years, 3 months ago (2013-09-05 00:36:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23874013/11001
7 years, 3 months ago (2013-09-05 01:07:24 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) ui_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=82885
7 years, 3 months ago (2013-09-05 01:36:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/23874013/11001
7 years, 3 months ago (2013-09-05 20:47:56 UTC) #9
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 22:14:54 UTC) #10
Message was sent while issue was closed. 
Change committed as 221529

Powered by Google App Engine
This is Rietveld 408576698