chrome/browser/ui/webui/ntp/ntp_user_data_logger.h - Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/local_ntp/most_visited_util.js ('K') | « chrome/browser/resources/local_ntp/most_visited_util.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

diff --git a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

index 41cd59d5fe7b594f498876b8963b1ea18cd38341..bfdfd20f4c53cce13c188c22d4876a6de3e8127c 100644

--- a/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

+++ b/chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

@@ -64,6 +64,14 @@ class NTPUserDataLogger

// of a thumbnail image.

size_t number_of_thumbnail_errors_;

+ // Total number of attempts made to load thumbnail images while providing a

+ // fallback thumbnail for this NTP session.

+ size_t number_of_thumbnail_with_fallback_attempts_;

Mathieu 2013/09/03 21:40:23 nit: number_of_fallback_thumbnails_requested_?

beaudoin 2013/09/03 22:34:55 Done.

+ // Total number of errors that occurred while trying to load the primary

+ // thumbnail image and that caused a fallback to the secondary thumbnail.

+ size_t number_of_thumbnail_fallbacks_;

Mathieu 2013/09/03 21:40:23 nit: number_of_fallback_thumbnails_used_?

beaudoin 2013/09/03 22:34:55 Done.

// The URL of this New Tab Page - varies based on NTP version.

GURL ntp_url_;