chrome/browser/resources/local_ntp/most_visited_util.js - Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p…

Unified Diff: chrome/browser/resources/local_ntp/most_visited_util.js

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/local_ntp/most_visited_thumbnail.js ('K') | « chrome/browser/resources/local_ntp/most_visited_thumbnail.js ('k') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('j') | chrome/browser/ui/webui/ntp/ntp_user_data_logger.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/local_ntp/most_visited_util.js

diff --git a/chrome/browser/resources/local_ntp/most_visited_util.js b/chrome/browser/resources/local_ntp/most_visited_util.js

index 446b7ca20e67b94c4491bc30b19f6c02bc538b35..ba0acbe43c4e98f32bb8db8cda7ce7d1faf77be2 100644

--- a/chrome/browser/resources/local_ntp/most_visited_util.js

+++ b/chrome/browser/resources/local_ntp/most_visited_util.js

@@ -20,7 +20,12 @@ var NTP_LOGGING_EVENT_TYPE = {

// The page attempted to load a thumbnail image.

NTP_THUMBNAIL_ATTEMPT: 1,

// There was an error in loading a thumbnail image.

Mathieu 2013/09/03 21:40:23 nit: update comment to mention this is the ultimat

beaudoin 2013/09/03 22:34:55 Done.

jeremycho 2013/09/04 20:53:57 Not done?

beaudoin 2013/09/05 12:47:32 Done.

- NTP_THUMBNAIL_ERROR: 2

+ NTP_THUMBNAIL_ERROR: 2,

+ // The page attempted to load a thumbnail image and provided a fallback.

Mathieu 2013/09/03 21:40:23 // The page was provided a fallback thumbnail URL,

beaudoin 2013/09/03 22:34:55 Rephrased a little. Done.

beaudoin 2013/09/05 12:47:32 Done done.

+ NTP_THUMBNAIL_WITH_FALLBACK_ATTEMPT: 3,

+ // The primary thumbnail image failed to load and caused a fallback to the

+ // secondary thumbnail.

+ NTP_THUMBNAIL_FALLBACK: 4

};

/**