Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Side by Side Diff: chrome/browser/ui/webui/ntp/ntp_user_data_logger.h

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_ 5 #ifndef CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_
6 #define CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_ 6 #define CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_
7 7
8 #include "chrome/common/ntp_logging_events.h" 8 #include "chrome/common/ntp_logging_events.h"
9 #include "content/public/browser/web_contents_observer.h" 9 #include "content/public/browser/web_contents_observer.h"
10 #include "content/public/browser/web_contents_user_data.h" 10 #include "content/public/browser/web_contents_user_data.h"
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 // Total number of attempts made to load thumbnail images for this NTP 58 // Total number of attempts made to load thumbnail images for this NTP
59 // session. 59 // session.
60 size_t number_of_thumbnail_attempts_; 60 size_t number_of_thumbnail_attempts_;
61 61
62 // Total number of errors that occurred when trying to load thumbnail images 62 // Total number of errors that occurred when trying to load thumbnail images
63 // for this NTP session. When these errors occur a grey tile is shown instead 63 // for this NTP session. When these errors occur a grey tile is shown instead
64 // of a thumbnail image. 64 // of a thumbnail image.
65 size_t number_of_thumbnail_errors_; 65 size_t number_of_thumbnail_errors_;
66 66
67 // Total number of attempts made to load thumbnail images while providing a
68 // fallback thumbnail for this NTP session.
69 size_t number_of_thumbnail_with_fallback_attempts_;
Mathieu 2013/09/03 21:40:23 nit: number_of_fallback_thumbnails_requested_?
beaudoin 2013/09/03 22:34:55 Done.
70
71 // Total number of errors that occurred while trying to load the primary
72 // thumbnail image and that caused a fallback to the secondary thumbnail.
73 size_t number_of_thumbnail_fallbacks_;
Mathieu 2013/09/03 21:40:23 nit: number_of_fallback_thumbnails_used_?
beaudoin 2013/09/03 22:34:55 Done.
74
67 // The URL of this New Tab Page - varies based on NTP version. 75 // The URL of this New Tab Page - varies based on NTP version.
68 GURL ntp_url_; 76 GURL ntp_url_;
69 77
70 DISALLOW_COPY_AND_ASSIGN(NTPUserDataLogger); 78 DISALLOW_COPY_AND_ASSIGN(NTPUserDataLogger);
71 }; 79 };
72 80
73 #endif // CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_ 81 #endif // CHROME_BROWSER_UI_WEBUI_NTP_NTP_USER_DATA_LOGGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698