chrome/browser/resources/local_ntp/most_visited_thumbnail.js - Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

Issue 23874005: Ensure the 1993 NTP logs to UMA Most Visited tiles that use the fallback thumbnail instead of the p… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/local_ntp/most_visited_thumbnail.js

diff --git a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

index 8952d70afa0f96be8442e3e61b9c752d7e85d707..60051eb97be9c92b8f5cccf4d14114a62a669f53 100644

--- a/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

+++ b/chrome/browser/resources/local_ntp/most_visited_thumbnail.js

@@ -51,9 +51,11 @@ window.addEventListener('DOMContentLoaded', function() {

// The first thumbnail's onerror function will swap the visibility of

// the two thumbnails.

image.onerror = function() {

+ logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_FALLBACK);

Mathieu 2013/09/03 21:40:23 NTP_FALLBACK_THUMBNAIL_USED?

beaudoin 2013/09/03 22:34:55 Done.

image.style.visibility = 'hidden';

image2.style.visibility = 'visible';

};

+ logEvent(NTP_LOGGING_EVENT_TYPE.NTP_THUMBNAIL_WITH_FALLBACK_ATTEMPT);

Mathieu 2013/09/03 21:40:23 nit: NTP_FALLBACK_THUMBNAIL_REQUESTED to be closer

beaudoin 2013/09/03 22:34:55 Done.

} else {

image.onerror = showDomainElement;

}

« no previous file with comments | « no previous file | chrome/browser/resources/local_ntp/most_visited_util.js » ('j') | chrome/browser/resources/local_ntp/most_visited_util.js » ('J')