Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index 8975be6473baf109fbe26ae0f6134f63f202d379..34ac01e7f6949c7af671f9ed3ce5201a18fec28e 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -580,6 +580,8 @@ void RenderFrameDevToolsAgentHost::OnClientDetached() {
#if defined(OS_ANDROID)
power_save_blocker_.reset();
#endif
+ if (input_handler_)
dgozman 2016/11/23 02:03:53 I think it's never null (created in constructor).
tdresser 2016/11/23 13:38:13 Looks like you're right. I'm not sure why this is
samuong 2016/11/23 18:40:48 Done. I removed the "if (input_handler_)", but I n
tdresser 2016/11/23 18:52:46 I'd be happy to see us stack allocated input_handl
+ input_handler_->Detached();
if (emulation_handler_)
emulation_handler_->Detached();
if (page_handler_)

Powered by Google App Engine
This is Rietveld 408576698