Delay Input.dispatchKeyEvent response until after key event ack.

content/browser/devtools/render_frame_devtools_agent_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/devtools/render_frame_devtools_agent_host.h"
 
 #include <tuple>
 #include <utility>
 
 #include "base/guid.h"
@@ skipping 562 matching lines @@
     return;
 
   frame_trace_recorder_.reset(new DevToolsFrameTraceRecorder());
   CreatePowerSaveBlocker();
 }
 
 void RenderFrameDevToolsAgentHost::OnClientDetached() {
 #if defined(OS_ANDROID)
   power_save_blocker_.reset();
 #endif
+  if (input_handler_)

[dgozman, 2016/11/23 02:03:53]

I think it's never null (created in constructor).

[tdresser, 2016/11/23 13:38:13]

Looks like you're right. I'm not sure why this is a unique_ptr, instead of being
stack allocated.

[samuong, 2016/11/23 18:40:48]

Done. I removed the "if (input_handler_)", but I noticed that it is checked
unnecessarily in a few other places too. Let me know if you want me to remove
these and I can submit it in a follow-up CL.

[tdresser, 2016/11/23 18:52:46]

I'd be happy to see us stack allocated input_handler_ in a followup CL.

+    input_handler_->Detached();
   if (emulation_handler_)
     emulation_handler_->Detached();
   if (page_handler_)
     page_handler_->Detached();
   service_worker_handler_->Detached();
   target_handler_->Detached();
   frame_trace_recorder_.reset();
   in_navigation_protocol_message_buffer_.clear();
 }
 
@@ skipping 547 matching lines @@
     RenderFrameHost* host) {
   return (current_ && current_->host() == host) ||
       (pending_ && pending_->host() == host);
 }
 
 bool RenderFrameDevToolsAgentHost::IsChildFrame() {
   return current_ && current_->host()->GetParent();
 }
 
 }  // namespace content