Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2387353004: Delay Input.dispatchKeyEvent response until after key event ack. (Closed)
Patch Set: fix test Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index c088b30459bec86e23e54cdb35844e697c1c7922..6be414de043198f88efb7550e0a8622d20e4b7e3 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -2148,6 +2148,8 @@ void RenderWidgetHostImpl::OnKeyboardEventAck(
const NativeWebKeyboardEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ for (auto& input_event_observer : input_event_observers_)
+ input_event_observer.OnInputEventAck(event.event);
const bool processed = (INPUT_EVENT_ACK_STATE_CONSUMED == ack_result);
@@ -2168,6 +2170,8 @@ void RenderWidgetHostImpl::OnMouseEventAck(
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(mouse_event.event, &mouse_event.latency,
ack_result);
+ for (auto& input_event_observer : input_event_observers_)
+ input_event_observer.OnInputEventAck(mouse_event.event);
}
void RenderWidgetHostImpl::OnWheelEventAck(
@@ -2175,6 +2179,8 @@ void RenderWidgetHostImpl::OnWheelEventAck(
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(wheel_event.event, &wheel_event.latency,
ack_result);
+ for (auto& input_event_observer : input_event_observers_)
+ input_event_observer.OnInputEventAck(wheel_event.event);
if (!is_hidden() && view_) {
if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED &&
@@ -2189,6 +2195,8 @@ void RenderWidgetHostImpl::OnGestureEventAck(
const GestureEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ for (auto& input_event_observer : input_event_observers_)
+ input_event_observer.OnInputEventAck(event.event);
if (view_)
view_->GestureEventAck(event.event, ack_result);
@@ -2198,6 +2206,8 @@ void RenderWidgetHostImpl::OnTouchEventAck(
const TouchEventWithLatencyInfo& event,
InputEventAckState ack_result) {
latency_tracker_.OnInputEventAck(event.event, &event.latency, ack_result);
+ for (auto& input_event_observer : input_event_observers_)
+ input_event_observer.OnInputEventAck(event.event);
if (touch_emulator_ &&
touch_emulator_->HandleTouchEventAck(event.event, ack_result)) {

Powered by Google App Engine
This is Rietveld 408576698