Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: third_party/WebKit/Source/core/inspector/browser_protocol.json

Issue 2387283003: [DevTools] Support all targets discovery in Target domain. (Closed)
Patch Set: small fix Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/browser_protocol.json
diff --git a/third_party/WebKit/Source/core/inspector/browser_protocol.json b/third_party/WebKit/Source/core/inspector/browser_protocol.json
index a2cf152e8b375e6550f106d5773545c68894de73..a48376b6f90c01ad732fcfa484ab578667783a46 100644
--- a/third_party/WebKit/Source/core/inspector/browser_protocol.json
+++ b/third_party/WebKit/Source/core/inspector/browser_protocol.json
@@ -3289,18 +3289,16 @@
],
"commands": [
{
- "name": "enable",
- "description": "Start discovering targets.",
- "handlers": ["browser"]
- },
- {
- "name": "disable",
- "description": "Stop discovering targets and detach from all currently attached targets.",
+ "name": "setDiscoverTargets",
+ "description": "Controls whether to discover available targets and notify via <code>targetCreated/targetRemoved</code> events.",
+ "parameters": [
+ { "name": "discover", "type": "boolean", "description": "Whether to discover available targets." }
+ ],
"handlers": ["browser"]
},
{
"name": "setAutoAttach",
- "description": "Controls whether to automatically attach to new targets which are considered to be related to this one. When turned on, attaches to all existing related targets as well. When turned off, does not automatically detach.",
+ "description": "Controls whether to automatically attach to new targets which are considered to be related to this one. When turned on, attaches to all existing related targets as well. When turned off, automatically detaches from all currently attached targets.",
"parameters": [
{ "name": "autoAttach", "type": "boolean", "description": "Whether to auto-attach to related targets." },
{ "name": "waitForDebuggerOnStart", "type": "boolean", "description": "Whether to pause new targets when attaching to them. Use <code>Runtime.runIfWaitingForDebugger</code> to run paused targets." }
@@ -3338,6 +3336,23 @@
{ "name": "targetId", "$ref": "TargetID" }
],
"handlers": ["browser"]
+ },
+ {
+ "name": "attachToTarget",
+ "parameters": [
+ { "name": "targetId", "$ref": "TargetID" }
+ ],
+ "returns": [
+ { "name": "success", "type": "boolean", "description": "Whether attach succeeded." }
+ ],
+ "handlers": ["browser"]
+ },
+ {
+ "name": "detachFromTarget",
+ "parameters": [
+ { "name": "targetId", "$ref": "TargetID" }
+ ],
+ "handlers": ["browser"]
}
],
"events": [

Powered by Google App Engine
This is Rietveld 408576698