[DevTools] Fix a couple of issues for cross-site RFDTAH, add a test.

[DevTools] Fix a couple of issues for cross-site RFDTAH, add a test.

- Fixed NPE in GetType(), GetTitle() and GetDescription().
- Fallback to default GetType() when not provided by delegate.
- Fixed UAF when CommitPending() destructed |this| (triggered in DHCECKs only).
- Test for Target domain with OOPIFs.

BUG=648775
Committed: https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa
Cr-Commit-Position: refs/heads/master@{#424358}

[pfeldman, 2016-10-05 23:18:03]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-10-05 23:22:19]

lgtm

[dgozman, 2016-10-06 02:09:44]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 02:10:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 02:13:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 02:13:30]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[dgozman, 2016-10-06 22:54:31]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 22:54:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 23:17:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 23:17:28]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-10-11 02:00:05]

The CQ bit was checked by dgozman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 02:00:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 02:40:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 02:40:44]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-11 03:09:17]

The CQ bit was checked by dgozman@chromium.org

[dgozman, 2016-10-11 03:09:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2397713003/#ps40001
(title: "test fix")

[commit-bot: I haz the power, 2016-10-11 03:09:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 03:18:06]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-11 03:22:42]

Description was changed from

==========
[DevTools] Fix a couple of issues for cross-site RFDTAH, add a test.

- Fixed NPE in GetType(), GetTitle() and GetDescription().
- Fallback to default GetType() when not provided by delegate.
- Fixed UAF when CommitPending() destructed |this| (triggered in DHCECKs only).
- Test for Target domain with OOPIFs.

BUG=648775
==========

to

==========
[DevTools] Fix a couple of issues for cross-site RFDTAH, add a test.

- Fixed NPE in GetType(), GetTitle() and GetDescription().
- Fallback to default GetType() when not provided by delegate.
- Fixed UAF when CommitPending() destructed |this| (triggered in DHCECKs only).
- Test for Target domain with OOPIFs.

BUG=648775

Committed: https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa
Cr-Commit-Position: refs/heads/master@{#424358}
==========

[commit-bot: I haz the power, 2016-10-11 03:22:44]

Patchset 3 (id:??) landed as
https://crrev.com/6aa558fd82627ea7acbf9affc3823367e43c74aa
Cr-Commit-Position: refs/heads/master@{#424358}