chrome/browser/extensions/chrome_extension_function.h - Issue 2386823002: [Extensions] Remove ExtensionFunction::SetError()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/chrome_extension_function.h

Issue 2386823002: [Extensions] Remove ExtensionFunction::SetError() (Closed)

Patch Set: Disable broken tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/chrome_extension_function.h

diff --git a/chrome/browser/extensions/chrome_extension_function.h b/chrome/browser/extensions/chrome_extension_function.h

index 59d5e1e0ad19324de4bbbe795683da57d1149514..5631d69645f8e796bc90b7501935735edf4ed02c 100644

--- a/chrome/browser/extensions/chrome_extension_function.h

+++ b/chrome/browser/extensions/chrome_extension_function.h

@@ -56,7 +56,7 @@ class ChromeUIThreadExtensionFunction : public UIThreadExtensionFunction {

// ExtensionFunction:

content::WebContents* GetAssociatedWebContents() override;

- void SetError(const std::string& error) override;

+ void SetError(const std::string& error);

lazyboy 2016/10/03 20:34:01 nit: move this out of "ExtensionFunction:" group s

Devlin 2016/10/03 23:07:50 Good call, done.

const std::string& GetError() const override;

protected: