Chromium Code Reviews| Index: extensions/browser/extension_function.h |
| diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h |
| index 03d6572921f0de46ca07eee9379afbae216bbebf..5cd4f378ffe4a5e38403728262dbd01d6af503bb 100644 |
| --- a/extensions/browser/extension_function.h |
| +++ b/extensions/browser/extension_function.h |
| @@ -243,10 +243,6 @@ class ExtensionFunction |
| // Retrieves any error string from the function. |
| virtual const std::string& GetError() const; |
| - // Sets the function's error string. |
| - // TODO(devlin): This should be handled exclusively through the responses. |
| - virtual void SetError(const std::string& error); |
| - |
| bool bad_message() const { return bad_message_; } |
| void set_bad_message(bool bad_message) { bad_message_ = bad_message; } |
| @@ -637,7 +633,7 @@ class AsyncExtensionFunction : public UIThreadExtensionFunction { |
| AsyncExtensionFunction(); |
| // ExtensionFunction: |
| - void SetError(const std::string& error) override; |
| + void SetError(const std::string& error); |
|
lazyboy
2016/10/03 20:34:01
Same here.
Devlin
2016/10/03 23:07:50
Done.
|
| const std::string& GetError() const override; |
| protected: |