Do not store TestRunner in WebFrameTestClient.

Do not store TestRunner* in WebViewTestClient and/or WebFrameTestClient.

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
and WebViewTestClient can both obtain the same pointer via another (also
borrowed) pointer they already have - one to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.
In the long-term we also should remove |delegate_| field from
WebFrameTestClient (responsible for UaF in https://crbug.com/606594).

BUG=595089
Committed: https://crrev.com/bdc126c7556aa6499acefbd0b3b4945cb46d08c3
Cr-Commit-Position: refs/heads/master@{#422901}

[Łukasz Anforowicz, 2016-09-30 18:19:23]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 18:20:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 20:39:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 20:39:05]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-09-30 20:42:12]

Description was changed from

==========
Do not store TestRunner in WebFrameTestClient.

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
can obtain the same pointer via another (also borrowed) pointer it
already has to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.

BUG=595089
==========

to

==========
Do not store TestRunner* in WebViewTestClient and/or WebFrameTestClient.

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
and WebViewTestClient can both obtain the same pointer via another (also
borrowed) pointer they already have - one to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.
In the long-term we also should remove |delegate_| field from
WebFrameTestClient (responsible for UaF in https://crbug.com/606594).

BUG=595089
==========

[Łukasz Anforowicz, 2016-09-30 20:42:43]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:43:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:24:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 22:25:00]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-09-30 23:20:03]

lukasza@chromium.org changed reviewers:
+ jochen@chromium.org

[Łukasz Anforowicz, 2016-09-30 23:20:03]

jochen@, can you take a look please?

What I really want is to get rid of the |delegate_| field in WebFrameTestClient,
but this is slow-going, so for now I am at least getting rid of the
|test_runner_| fields :-)

[jochen (gone - plz use gerrit), 2016-10-04 14:42:26]

lgtm

[Łukasz Anforowicz, 2016-10-04 15:20:09]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-10-04 15:20:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 15:32:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 15:32:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Łukasz Anforowicz, 2016-10-04 18:33:11]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-10-04 18:33:12]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2386683002/#ps80001
(title: "s/test_runner_/test_runner()/ for one case pulled after rebasing.")

[commit-bot: I haz the power, 2016-10-04 18:33:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 20:21:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-04 20:23:41]

Description was changed from

==========
Do not store TestRunner* in WebViewTestClient and/or WebFrameTestClient.

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
and WebViewTestClient can both obtain the same pointer via another (also
borrowed) pointer they already have - one to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.
In the long-term we also should remove |delegate_| field from
WebFrameTestClient (responsible for UaF in https://crbug.com/606594).

BUG=595089
==========

to

==========
Do not store TestRunner* in WebViewTestClient and/or WebFrameTestClient.

Instead of storing borrowed pointer to TestRunner, WebFrameTestClient
and WebViewTestClient can both obtain the same pointer via another (also
borrowed) pointer they already have - one to WebViewTestProxyBase.

Less fields to worry about (e.g. wrt lifetime management) is good.
In the long-term we also should remove |delegate_| field from
WebFrameTestClient (responsible for UaF in https://crbug.com/606594).

BUG=595089

Committed: https://crrev.com/bdc126c7556aa6499acefbd0b3b4945cb46d08c3
Cr-Commit-Position: refs/heads/master@{#422901}
==========

[commit-bot: I haz the power, 2016-10-04 20:23:42]

Patchset 5 (id:??) landed as
https://crrev.com/bdc126c7556aa6499acefbd0b3b4945cb46d08c3
Cr-Commit-Position: refs/heads/master@{#422901}