Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: components/test_runner/web_view_test_client.h

Issue 2386683002: Do not store TestRunner in WebFrameTestClient. (Closed)
Patch Set: s/test_runner_/test_runner()/ for one case pulled after rebasing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/test_runner/web_test_interfaces.cc ('k') | components/test_runner/web_view_test_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_view_test_client.h
diff --git a/components/test_runner/web_view_test_client.h b/components/test_runner/web_view_test_client.h
index 21b8c6117ca27077a39bb1d68b0d71123af258b7..a8b3c723135e970d1d319a603a7a7fd8509d252b 100644
--- a/components/test_runner/web_view_test_client.h
+++ b/components/test_runner/web_view_test_client.h
@@ -25,10 +25,8 @@ class WebViewTestProxyBase;
// WebViewTestClient or to the product code (i.e. to RenderViewImpl).
class WebViewTestClient : public blink::WebViewClient {
public:
- // Caller has to ensure that all arguments (i.e. |test_runner| and |delegate|)
- // live longer than |this|.
- WebViewTestClient(TestRunner* test_runner,
- WebViewTestProxyBase* web_view_test_proxy_base);
+ // Caller has to ensure |web_view_test_proxy_base| lives longer than |this|.
+ WebViewTestClient(WebViewTestProxyBase* web_view_test_proxy_base);
virtual ~WebViewTestClient();
@@ -58,9 +56,9 @@ class WebViewTestClient : public blink::WebViewClient {
private:
WebTestDelegate* delegate();
+ TestRunner* test_runner();
- // Borrowed pointers to other parts of Layout Tests state.
- TestRunner* test_runner_;
+ // Borrowed pointer to WebViewTestProxyBase.
WebViewTestProxyBase* web_view_test_proxy_base_;
DISALLOW_COPY_AND_ASSIGN(WebViewTestClient);
« no previous file with comments | « components/test_runner/web_test_interfaces.cc ('k') | components/test_runner/web_view_test_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698