Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: components/test_runner/web_frame_test_client.h

Issue 2386683002: Do not store TestRunner in WebFrameTestClient. (Closed)
Patch Set: s/test_runner_/test_runner()/ for one case pulled after rebasing. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/test_runner/web_frame_test_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/test_runner/web_frame_test_client.h
diff --git a/components/test_runner/web_frame_test_client.h b/components/test_runner/web_frame_test_client.h
index 8d07311f039e4d1b1d84775f0383708e4447900d..e30e605b9dcbe95c22597e0a9955e45f7bf98ac5 100644
--- a/components/test_runner/web_frame_test_client.h
+++ b/components/test_runner/web_frame_test_client.h
@@ -25,10 +25,9 @@ class WebViewTestProxyBase;
// WebFrameTestClient or to the product code (i.e. to RenderFrameImpl).
class WebFrameTestClient : public blink::WebFrameClient {
public:
- // Caller has to ensure that all arguments (|test_runner|, |delegate| and so
- // forth) live longer than |this|.
- WebFrameTestClient(TestRunner* test_runner,
- WebTestDelegate* delegate,
+ // Caller has to ensure that all arguments (|delegate|,
+ // |web_view_test_proxy_base_| and so forth) live longer than |this|.
+ WebFrameTestClient(WebTestDelegate* delegate,
WebViewTestProxyBase* web_view_test_proxy_base,
WebFrameTestProxyBase* web_frame_test_proxy_base);
@@ -108,8 +107,9 @@ class WebFrameTestClient : public blink::WebFrameClient {
blink::WebEffectiveConnectionType getEffectiveConnectionType() override;
private:
+ TestRunner* test_runner();
+
// Borrowed pointers to other parts of Layout Tests state.
- TestRunner* test_runner_;
WebTestDelegate* delegate_;
WebViewTestProxyBase* web_view_test_proxy_base_;
WebFrameTestProxyBase* web_frame_test_proxy_base_;
« no previous file with comments | « no previous file | components/test_runner/web_frame_test_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698